GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.10] gh-82006: IDLE doc improvements (GH-94349) by miss-islington · Pull Request #94358 · python/cpython

Conversation

@miss-islington

@miss-islington miss-islington commented Jun 27, 2022 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor
  1. Update text start and stop conditions.
  2. Title-case sections but not subsections.
  3. Edit Shell Window sections: title, execute, restart.
    (cherry picked from commit e6391e0)

Co-authored-by: Terry Jan Reedy [email protected]

  • Issue: IDLE doc improvements #82006

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@terryjreedy @miss-islington
pythongh-82006: IDLE doc improvements (pythonGH-94349)
559776f 
0. Update text start and stop conditions.
1. Title-case sections but not subsections.
2. Edit Shell Window sections: title, execute, restart.
(cherry picked from commit e6391e0)

Co-authored-by: Terry Jan Reedy <[email protected]>
@miss-islington
miss-islington requested a review from terryjreedy as a code owner June 27, 2022 22:59
@miss-islington

miss-islington commented Jun 27, 2022

Copy link
Copy Markdown
Contributor Author

Status check is done, and it's a success ✅ .
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot added the awaiting review label Jun 27, 2022
@bedevere-bot bedevere-bot mentioned this pull request Jun 27, 2022
gh-82006: IDLE doc improvements #94349
Merged
@bedevere-bot bedevere-bot added the skip news label Jun 27, 2022
terryjreedy
terryjreedy approved these changes Jun 27, 2022
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting review labels Jun 27, 2022
@miss-islington

miss-islington commented Jun 27, 2022

Copy link
Copy Markdown
Contributor Author

@terryjreedy: Status check is done, and it's a success ❌ .
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
1 similar comment
@miss-islington

miss-islington commented Jun 27, 2022

Copy link
Copy Markdown
Contributor Author

@terryjreedy: Status check is done, and it's a success ❌ .
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@terryjreedy

terryjreedy commented Jun 27, 2022

Copy link
Copy Markdown
Member

@ezio-melotti @JulienPalard The Docs/Docs test failed with

Warning, treated as error:
[library/idle:597] "`" found in "Lines containing`’RESTART’` mean that the user execution process has been"
make[1]: *** [Makefile:51: build] Error 2
make: *** [Makefile:115: suspicious] Error 1
make[1]: Leaving directory '/home/runner/work/cpython/cpython/Doc'
Suspicious check complete; look for any errors in the above output or in build/suspicious/suspicious.csv.  If all issues are false positives, append that file to tools/susp-ignored.csv.
make: Leaving directory '/home/runner/work/cpython/cpython/Doc'
Error: Process completed with exit code 2.

(I noticed the missing ' '.) This same test passed for main and 3.11, and for main, the resulting .html looks OK.
Why fail here?

Since this is not required, I could commit anyway. Any problem? Or ask someone else?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@terryjreedy terryjreedy closed this Jun 27, 2022
@terryjreedy terryjreedy reopened this Jun 28, 2022
@miss-islington

miss-islington commented Jun 28, 2022

Copy link
Copy Markdown
Contributor Author

@terryjreedy: Status check is done, and it's a success ❌ .
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
4 similar comments
@miss-islington

miss-islington commented Jun 28, 2022

Copy link
Copy Markdown
Contributor Author

@terryjreedy: Status check is done, and it's a success ❌ .
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington

miss-islington commented Jun 28, 2022

Copy link
Copy Markdown
Contributor Author

@terryjreedy: Status check is done, and it's a success ❌ .
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington

miss-islington commented Jun 28, 2022

Copy link
Copy Markdown
Contributor Author

@terryjreedy: Status check is done, and it's a success ❌ .
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington

miss-islington commented Jun 28, 2022

Copy link
Copy Markdown
Contributor Author

@terryjreedy: Status check is done, and it's a success ❌ .
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ambv
Fix ReST
67a67f1
@ambv ambv mentioned this pull request Jun 28, 2022
gh-86404: [doc] Fix missing space in idle documentation. #94366
Merged
@ambv
ambv merged commit eb7d354 into python:3.10 Jun 28, 2022
@bedevere-bot bedevere-bot removed the awaiting merge label Jun 28, 2022
@miss-islington
miss-islington deleted the backport-e6391e0-3.10 branch June 28, 2022 10:51
@terryjreedy

terryjreedy commented Jun 28, 2022

Copy link
Copy Markdown
Member

@JulienPalard @ambv Thank you both for the fixes which result in all 3 versions looking the same.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@terryjreedy terryjreedy terryjreedy approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@miss-islington @terryjreedy @ambv @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.