GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.11] GH-93516: Drop broken assert, fixes GH-93769 by tiran · Pull Request #94411 · python/cpython

Conversation

@tiran

@tiran tiran commented Jun 29, 2022 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

The assert is broken on big endian platforms and not present in the
main branch. Drop it.

Correct version would be _PyOpcode_Deopt[_Py_OPCODE(...)] instead of
_PyOpcode_Deopt[...].

  • Issue: Severe performance degradation for tracing under 3.11 #93516

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
gpshead reacted with hooray emoji
All reactions
  • 🎉 1 reaction
@tiran
[3.11] pythonGH-93516: Drop broken assert, fixes pythonGH-93769
8fd8bc4 
The ``assert`` is broken on big endian platforms and not present in the
main branch. Drop it.

Correct version would be ``_PyOpcode_Deopt[_Py_OPCODE(...)]`` instead of
``_PyOpcode_Deopt[...]``.
@tiran
tiran requested a review from markshannon as a code owner June 29, 2022 10:46
@bedevere-bot bedevere-bot added the awaiting core review label Jun 29, 2022
@tiran tiran added skip news 🔨 test-with-buildbots Test PR w/ buildbots; report in status section labels Jun 29, 2022
@bedevere-bot

bedevere-bot commented Jun 29, 2022

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @tiran for commit 8fd8bc4 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Jun 29, 2022
@tiran tiran mentioned this pull request Jun 29, 2022
Python 3.11: Assertion `_PyOpcode_Deopt[first_instr[frame->f_code->_co_firsttraceable]] == RESUME' failed #94412
Closed
@markshannon

markshannon commented Jun 29, 2022

Copy link
Copy Markdown
Member

Thanks
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@markshannon
markshannon merged commit 9140c41 into python:3.11 Jun 29, 2022
@bedevere-bot bedevere-bot removed the awaiting core review label Jun 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@markshannon markshannon Awaiting requested review from markshannon markshannon is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@tiran @bedevere-bot @markshannon
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.