GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.10] gh-84753: Make inspect.iscoroutinefunction() work with AsyncMock (GH-94050) by miss-islington · Pull Request #94461 · python/cpython

Conversation

@miss-islington

@miss-islington miss-islington commented Jun 30, 2022 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

The inspect version was not working with unittest.mock.AsyncMock.

The fix introduces special-casing of AsyncMock in
inspect.iscoroutinefunction equivalent to the one
performed in asyncio.iscoroutinefunction.

Co-authored-by: Łukasz Langa [email protected]
(cherry picked from commit 4261b6b)

Co-authored-by: Mehdi ABAAKOUK [email protected]

  • Issue: inspect.iscorutinefunction() returns False for unittest.mock.AsyncMock instances #84753

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@sileht @miss-islington
pythongh-84753: Make inspect.iscoroutinefunction() work with AsyncMock (
c2879e4 
pythonGH-94050)

The inspect version was not working with unittest.mock.AsyncMock.

The fix introduces special-casing of AsyncMock in
`inspect.iscoroutinefunction` equivalent to the one
performed in `asyncio.iscoroutinefunction`.

Co-authored-by: Łukasz Langa <[email protected]>
(cherry picked from commit 4261b6b)

Co-authored-by: Mehdi ABAAKOUK <[email protected]>
@miss-islington
miss-islington requested review from 1st1, asvetlov and cjw296 as code owners June 30, 2022 17:09
@bedevere-bot bedevere-bot added the awaiting review label Jun 30, 2022
@miss-islington

miss-islington commented Jun 30, 2022

Copy link
Copy Markdown
Contributor Author

@sileht and @ambv: Status check is done, and it's a pending ❌ .
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot mentioned this pull request Jun 30, 2022
gh-84753: Make inspect.iscoroutinefunction() work with AsyncMock #94050
Merged
@miss-islington

miss-islington commented Jun 30, 2022

Copy link
Copy Markdown
Contributor Author

Status check is done, and it's a success ✅ .
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
1 similar comment
@miss-islington

miss-islington commented Jun 30, 2022

Copy link
Copy Markdown
Contributor Author

Status check is done, and it's a success ✅ .
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ambv
ambv merged commit 47f23b2 into python:3.10 Jun 30, 2022
@bedevere-bot bedevere-bot removed the awaiting review label Jun 30, 2022
@miss-islington
miss-islington deleted the backport-4261b6b-3.10 branch June 30, 2022 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cjw296 cjw296 Awaiting requested review from cjw296 cjw296 is a code owner
@1st1 1st1 Awaiting requested review from 1st1 1st1 is a code owner
@asvetlov asvetlov Awaiting requested review from asvetlov asvetlov is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@miss-islington @ambv @bedevere-bot @sileht
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.