GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-94512: Fix forced arg format in AC-processed winreg by arhadthedev · Pull Request #94513 · python/cpython

Conversation

@arhadthedev

@arhadthedev arhadthedev commented Jul 2, 2022 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • Issue: Fix forced arg format in AC-processed modules with custom converters #94512

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@arhadthedev
Fix forcing of arg format in AC-processed winreg
e911a52
@arhadthedev
arhadthedev requested a review from a team as a code owner July 2, 2022 19:35
@bedevere-bot bedevere-bot added the awaiting review label Jul 2, 2022
@arhadthedev arhadthedev mentioned this pull request Jul 2, 2022
Fix forced arg format in AC-processed modules with custom converters #94512
Open
6 of 7 tasks
@arhadthedev
Add a NEWS entry
44e8e53
zooba
zooba reviewed Jul 4, 2022
View reviewed changes
Comment thread Misc/NEWS.d/next/Library/2022-07-03-22-58-42.gh-issue-94512.W-g4ff.rst Outdated
@@ -0,0 +1 @@
Convert :mod:`winreg` to use Argument Clinic.

@zooba zooba Jul 4, 2022

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was already using it?

If this is a completely invisible change to users, we don't need a NEWS entry.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@arhadthedev arhadthedev Jul 4, 2022

Copy link
Copy Markdown
Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, done.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@zooba zooba added the skip news label Jul 4, 2022
@arhadthedev
Revert "Add a NEWS entry"
8de1504 
This reverts commit 44e8e53.
@zooba
zooba merged commit 9b50f76 into python:main Jul 4, 2022
@bedevere-bot bedevere-bot removed the awaiting review label Jul 4, 2022
@arhadthedev
arhadthedev deleted the clinic-winreg-deformat branch July 4, 2022 13:22
@serhiy-storchaka serhiy-storchaka mentioned this pull request Aug 9, 2026
gh-90872: Use strict unsigned long conversion for DWORD values #32081
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zooba zooba zooba left review comments

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@arhadthedev @zooba @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.