GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-94512: Fix forced arg format in AC-processed msvcrtmodule by arhadthedev · Pull Request #94514 · python/cpython

Conversation

@arhadthedev

@arhadthedev arhadthedev commented Jul 2, 2022 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • Issue: Fix forced arg format in AC-processed modules with custom converters #94512

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@arhadthedev
Fix forced arg format in AC-processed msvcrtmodule
02d972f
@arhadthedev
arhadthedev requested a review from a team as a code owner July 2, 2022 19:41
@bedevere-bot bedevere-bot added the awaiting review label Jul 2, 2022
@arhadthedev arhadthedev mentioned this pull request Jul 2, 2022
Fix forced arg format in AC-processed modules with custom converters #94512
Open
6 of 7 tasks
arhadthedev added 2 commits July 2, 2022 23:23
@arhadthedev
Use proper sentinel value for a pointer
d1bf0ab
@arhadthedev
Add a NEWS entry
450875a
@zooba zooba added the skip news label Jul 4, 2022
zooba
zooba reviewed Jul 4, 2022
View reviewed changes
Comment thread Misc/NEWS.d/next/Library/2022-07-03-23-06-09.gh-issue-94512.W-g4ff.rst Outdated
@@ -0,0 +1 @@
Convert :mod:`msvcrt` to use Argument Clinic.

@zooba zooba Jul 4, 2022

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just remove - we don't need NEWS for this.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@arhadthedev arhadthedev Jul 4, 2022

Copy link
Copy Markdown
Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@arhadthedev
Revert "Add a NEWS entry"
2321a3d 
This reverts commit 450875a.
@zooba
zooba merged commit 21f6b4d into python:main Jul 4, 2022
@bedevere-bot bedevere-bot removed the awaiting review label Jul 4, 2022
@arhadthedev
arhadthedev deleted the clinic-msvcrtmodule-deformat branch July 4, 2022 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zooba zooba zooba left review comments

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@arhadthedev @zooba @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.