GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-93963: Document importlib.abc deprecations by hugovk · Pull Request #94546 · python/cpython

Conversation

@hugovk

@hugovk hugovk commented Jul 4, 2022 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Follow up to #93965 (and re-using its issue number, let me know if we need a new one).

Document the deprecations made in issue #93963 / PR #93965.

  • Issue: Officially deprecate and remove abcs in importlib.abc moved to importlib.resources. #93963

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@hugovk
pythongh-93963: Document importlib.abc deprecations
f171aa2
@bedevere-bot bedevere-bot added awaiting review docs Documentation in the Doc dir labels Jul 4, 2022
@hugovk hugovk added the skip news label Jul 4, 2022
@hugovk
hugovk requested review from jaraco and warsaw July 4, 2022 09:51
@warsaw

warsaw commented Jul 4, 2022

Copy link
Copy Markdown
Member

How does this relate to #93611
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@hugovk

hugovk commented Jul 5, 2022

Copy link
Copy Markdown
Member Author

Let's ask @encukou:

Some new deprecations were added in #93965, but not documented.

Your #93611 does some restructuring, and given you want to limit its scope, should these deprecations be documented before or after that PR is landed?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ambv
ambv merged commit 10b12dd into python:main Jul 25, 2022
@bedevere-bot bedevere-bot removed the awaiting review label Jul 25, 2022
@hugovk
hugovk deleted the 93963-document-importlib.abc-deprecations branch July 25, 2022 17:21
@jaraco jaraco mentioned this pull request Jul 27, 2022
Officially deprecate and remove abcs in importlib.abc moved to importlib.resources. #93963
Closed
4 of 5 tasks
@encukou

encukou commented Jul 28, 2022

Copy link
Copy Markdown
Member

Sorry for missing that notification, and thanks Łukasz for merging both!
hugovk reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@jaraco jaraco mentioned this pull request Jul 29, 2022
gh-93963: Remove deprecated names from importlib.abc. #94528
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jaraco jaraco Awaiting requested review from jaraco jaraco is a code owner
@warsaw warsaw Awaiting requested review from warsaw warsaw is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@hugovk @warsaw @encukou @ambv @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.