GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-94309: Deprecate typing.Hashable/Sized by MonadChains · Pull Request #94626 · python/cpython

Conversation

@MonadChains

@MonadChains MonadChains commented Jul 6, 2022 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

#94309
To be consistent with PEP 585, deprecated aliases should not raise any DeprecationWarning.

I put as first version of deprecation the upcoming Python 3.12 (I am not fully sure about this though).

  • Issue: Deprecate typing.Hashable/Sized #94309

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
MonadChains added 2 commits July 6, 2022 23:59
@MonadChains
pythongh-94309: Deprecate typing.Hashable/Sized
b916294 
To be consistent with PEP 585, deprecated aliases should not raise any DeprecationWarning.
@MonadChains
polished deprecation message
aa7a8a3
@MonadChains
MonadChains requested review from Fidget-Spinner, JelleZijlstra and gvanrossum as code owners July 6, 2022 22:14
@ghost

ghost commented Jul 6, 2022 •
edited by ghost
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

All commit authors signed the Contributor License Agreement.
CLA signed
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot added the awaiting review label Jul 6, 2022
@bedevere-bot

bedevere-bot commented Jul 6, 2022

Copy link
Copy Markdown

Most changes to Python require a NEWS entry.

Please add it using the blurb_it web app or the blurb command-line tool.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot added the docs Documentation in the Doc dir label Jul 6, 2022
@blurb-it
📜🤖 Added by blurb_it.
6f155c8
@MonadChains MonadChains changed the title Gh 94309/deprecate hashed sized gh-94309: Deprecate typing.Hashable/Sized Jul 6, 2022
Fidget-Spinner
Fidget-Spinner reviewed Jul 7, 2022
View reviewed changes

@Fidget-Spinner Fidget-Spinner left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deprecating in 3.12 is correct. I think this is almost ready to merge. Good work!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
MonadChains reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
Comment thread Doc/library/typing.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
@AlexWaygood AlexWaygood added topic-typing type-feature A feature request or enhancement labels Jul 7, 2022
AlexWaygood
AlexWaygood reviewed Jul 7, 2022
View reviewed changes

@AlexWaygood AlexWaygood left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a row to this table at the bottom of the page, as well? https://docs.python.org/3.12/library/typing.html#deprecation-timeline-of-major-features

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Fidget-Spinner and MonadChains reacted with thumbs up emoji
All reactions
  • 👍 2 reactions
@MonadChains
Polish description and add list deprecation
4551aac
Fidget-Spinner
Fidget-Spinner approved these changes Jul 8, 2022
View reviewed changes

@Fidget-Spinner Fidget-Spinner left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting review labels Jul 8, 2022
AlexWaygood
AlexWaygood approved these changes Jul 8, 2022
View reviewed changes

@AlexWaygood AlexWaygood left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM too!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
kumaraditya303
kumaraditya303 approved these changes Jul 9, 2022
View reviewed changes
gvanrossum
gvanrossum approved these changes Jul 9, 2022
View reviewed changes
@Fidget-Spinner
Fidget-Spinner merged commit e8e4b55 into python:main Jul 10, 2022
@bedevere-bot bedevere-bot removed the awaiting merge label Jul 10, 2022
@Fidget-Spinner

Fidget-Spinner commented Jul 10, 2022

Copy link
Copy Markdown
Member

@MonadChains congrats on your first contribution to CPython 🎉 . I look forward to more of your contributions in the future.
AlexWaygood and hugovk reacted with hooray emoji
All reactions
  • 🎉 2 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@AlexWaygood AlexWaygood mentioned this pull request Jul 10, 2022
Deprecate typing.Hashable/Sized #94309
Closed
@hugovk

hugovk commented Jul 10, 2022

Copy link
Copy Markdown
Member

Shall we also add this to "What’s New In Python 3.12" in the docs?

Because we don't have a set version for removal, it can go in the "Pending Removal in Future Versions" section:

https://docs.python.org/3.12/whatsnew/3.12.html#pending-removal-in-future-versions

(Sorry for the late suggestion!)
AlexWaygood and MonadChains reacted with thumbs up emoji
All reactions
  • 👍 2 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Fidget-Spinner

Fidget-Spinner commented Jul 10, 2022

Copy link
Copy Markdown
Member

Shall we also add this to "What’s New In Python 3.12" in the docs?

Yes we should.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@MonadChains
MonadChains deleted the gh-94309/deprecate-hashed-sized branch July 10, 2022 23:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gvanrossum gvanrossum gvanrossum approved these changes
@Fidget-Spinner Fidget-Spinner Fidget-Spinner approved these changes
@kumaraditya303 kumaraditya303 kumaraditya303 approved these changes
@AlexWaygood AlexWaygood AlexWaygood approved these changes
@JelleZijlstra JelleZijlstra Awaiting requested review from JelleZijlstra JelleZijlstra is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

docs Documentation in the Doc dir topic-typing type-feature A feature request or enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

7 participants

@MonadChains @bedevere-bot @Fidget-Spinner @hugovk @gvanrossum @kumaraditya303 @AlexWaygood
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.