GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-93649: Fix dependencies of _testcapi by tiran · Pull Request #94695 · python/cpython

Conversation

@tiran

@tiran tiran commented Jul 8, 2022 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • header files are located in $(srcdir)
  • dependencies must not list C files that are also in a makesetup Setup
    file
  • Issue: Split up _testcapimodule.c #93649

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
erlend-aasland reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@tiran
pythongh-93649: Fix dependencies of _testcapi
35b1153 
- header files are located in $(srcdir)
- dependencies must not list C files that are also in a makesetup Setup
  file
@bedevere-bot bedevere-bot added the awaiting core review label Jul 8, 2022
@tiran tiran mentioned this pull request Jul 8, 2022
gh-93649: Split vectorcall testing from _testcapimodule.c #94549
Merged
@tiran tiran added skip news build The build process and cross-build labels Jul 8, 2022
@tiran
Also generate SRCDIRS for OOT builds
a09b7e3
@tiran
tiran merged commit 18ef240 into python:main Jul 9, 2022
@bedevere-bot bedevere-bot removed the awaiting core review label Jul 9, 2022
@tiran
tiran deleted the gh-93649-fix branch July 9, 2022 11:01
@tiran tiran mentioned this pull request Jul 9, 2022
GH-93252: Fix error handling for failed Python calls #94693
Merged
@erlend-aasland erlend-aasland mentioned this pull request Nov 14, 2022
Split up _testcapimodule.c #93649
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

build The build process and cross-build skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@tiran @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.