GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.11] GH-93252: Fix error handling for failed Python calls (GH-94693) by tiran · Pull Request #94707 · python/cpython

Conversation

@tiran

@tiran tiran commented Jul 9, 2022 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

(cherry picked from commit 8a285df)

Co-authored-by: Brandt Bucher [email protected]

  • Issue: Python/pystate.c:2218: _PyThreadState_PopFrame: Assertion `tstate->datastack_top >= base' failed. #93252

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
brandtbucher and others added 2 commits July 9, 2022 13:27
@brandtbucher @tiran
[3.11] pythonGH-93252: Fix error handling for failed Python calls (py…
305cfe8 
…thonGH-94693)

(cherry picked from commit 8a285df)

Co-authored-by: Brandt Bucher <[email protected]>
@tiran
Drop assert, 3.11 does not have co_framesize from pythonGH-93908
a1ec06d
@tiran
tiran requested a review from markshannon as a code owner July 9, 2022 11:33
@bedevere-bot bedevere-bot added type-crash A hard crash of the interpreter, possibly with a core dump awaiting core review labels Jul 9, 2022
@tiran
tiran requested a review from brandtbucher July 9, 2022 11:33
@tiran

tiran commented Jul 9, 2022

Copy link
Copy Markdown
Member Author

I have removed the failing assert. 3.11 does not have co_framesize. GH-93908 was not backported to 3.11.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@tiran tiran mentioned this pull request Jul 9, 2022
[3.11] GH-93252: Fix error handling for failed Python calls (GH-94693) #94699
Closed
@kumaraditya303

kumaraditya303 commented Jul 9, 2022

Copy link
Copy Markdown
Contributor

I have removed the failing assert. 3.11 does not have co_framesize. GH-93908 was not backported to 3.11.

Looks like we both created backport at the same time. #94708 has correct assert for 3.11.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@tiran

tiran commented Jul 9, 2022

Copy link
Copy Markdown
Member Author

Let's use your backport.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@tiran tiran closed this Jul 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@markshannon markshannon Awaiting requested review from markshannon markshannon is a code owner
@brandtbucher brandtbucher Awaiting requested review from brandtbucher

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

awaiting core review type-crash A hard crash of the interpreter, possibly with a core dump

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@tiran @kumaraditya303 @bedevere-bot @brandtbucher
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.