GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — GH-94851: check refcnt of immortal objects after finalization by kumaraditya303 · Pull Request #95001 · python/cpython

Conversation

@kumaraditya303

@kumaraditya303 kumaraditya303 commented Jul 19, 2022 •
edited by miss-islington
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor
  • Issue: Check for ref counting bugs in debug mode caused by immortal objects. #94851

Automerge-Triggered-By: GH:ericsnowcurrently

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-bot bedevere-bot added the awaiting review label Jul 19, 2022
@kumaraditya303 kumaraditya303 added the skip news label Jul 19, 2022
@kumaraditya303
kumaraditya303 force-pushed the global-objects branch 2 times, most recently from 41d0cfc to f66d0ce Compare July 20, 2022 06:40
@kumaraditya303 kumaraditya303 mentioned this pull request Jul 20, 2022
GH-94851: fix immortal objects refcounting in compiler #95040
Merged
@kumaraditya303
check refcnt after finalization
21ced2f
@kumaraditya303
kumaraditya303 force-pushed the global-objects branch from f66d0ce to 21ced2f Compare July 20, 2022 09:54
@kumaraditya303 kumaraditya303 added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Jul 20, 2022
@bedevere-bot

bedevere-bot commented Jul 20, 2022

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @kumaraditya303 for commit 21ced2f 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Jul 20, 2022
@kumaraditya303
kumaraditya303 requested a review from ericsnowcurrently July 20, 2022 14:49
@kumaraditya303
kumaraditya303 marked this pull request as ready for review July 20, 2022 14:49
ericsnowcurrently
ericsnowcurrently requested changes Jul 21, 2022
View reviewed changes

@ericsnowcurrently ericsnowcurrently left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than one small thing, LGTM. I suspect we will rip this out once (if) PEP 683 lands. Even then this is a helpful stopgap.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread Tools/scripts/generate_global_objects.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the awaiting review label Jul 21, 2022
@bedevere-bot

bedevere-bot commented Jul 21, 2022

Copy link
Copy Markdown

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot added the awaiting changes label Jul 21, 2022
kumaraditya303 added 2 commits July 22, 2022 10:48
@kumaraditya303
use constant
3c039cc
@kumaraditya303
formatting
c210c73
tiran
tiran reviewed Jul 22, 2022
View reviewed changes
Comment thread Tools/scripts/generate_global_objects.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
@kumaraditya303
kumaraditya303 requested a review from ericsnowcurrently July 22, 2022 16:10
ericsnowcurrently
ericsnowcurrently requested changes Jul 22, 2022
View reviewed changes

@ericsnowcurrently ericsnowcurrently left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding the constant! There's a comment to add and then this should be ready to merge.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread Include/internal/pycore_object.h Resolved

Uh oh!

There was an error while loading. Please reload this page.
@kumaraditya303 @ericsnowcurrently
Update Include/internal/pycore_object.h
be56017 
Co-authored-by: Eric Snow <[email protected]>
@kumaraditya303
kumaraditya303 requested a review from ericsnowcurrently July 22, 2022 17:56
@kumaraditya303
Merge branch 'main' into global-objects
6c10f91
ericsnowcurrently
ericsnowcurrently approved these changes Jul 25, 2022
View reviewed changes

@ericsnowcurrently ericsnowcurrently left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting changes labels Jul 25, 2022
@ericsnowcurrently ericsnowcurrently added the 🤖 automerge label Jul 25, 2022
@miss-islington
miss-islington merged commit 73ee5a6 into python:main Jul 25, 2022
@bedevere-bot bedevere-bot removed the awaiting merge label Jul 25, 2022
@kumaraditya303
kumaraditya303 deleted the global-objects branch July 25, 2022 17:44
@kumaraditya303

kumaraditya303 commented Jul 25, 2022

Copy link
Copy Markdown
Contributor Author

Thanks for the reviews @ericsnowcurrently!
ericsnowcurrently reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@kumaraditya303 kumaraditya303 mentioned this pull request Jul 25, 2022
Check for ref counting bugs in debug mode caused by immortal objects. #94851
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ericsnowcurrently ericsnowcurrently ericsnowcurrently approved these changes
+1 more reviewer
@tiran tiran tiran left review comments
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@kumaraditya303 @bedevere-bot @tiran @ericsnowcurrently @miss-islington
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.