GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-95335: extract 'struct cfg_builder' from the compiler so that the CFG can be manipulated directly by iritkatriel · Pull Request #95107 · python/cpython

Conversation

@iritkatriel

@iritkatriel iritkatriel commented Jul 21, 2022 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

This further decouples the compiler struct from parts of the compilation process, and in particular enables CFG construction without a compiler (which is useful for unit tests).

  • Issue: test_compiler_recursion_limit fails on wasm32-wasi #95335

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@iritkatriel
pythongh-93678: extract 'struct cfg' from the compiler so that the CF…
98b4902 
…G can be manipulated directly
@iritkatriel
iritkatriel requested a review from markshannon as a code owner July 21, 2022 20:09
@bedevere-bot bedevere-bot added the awaiting core review label Jul 21, 2022
@iritkatriel iritkatriel added skip news interpreter-core (Objects, Python, Grammar, and Parser dirs) labels Jul 21, 2022
@iritkatriel
add two missing static qualifiers
4bbebf8
@iritkatriel iritkatriel added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Jul 21, 2022
@bedevere-bot

bedevere-bot commented Jul 21, 2022

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @iritkatriel for commit 4bbebf8 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Jul 21, 2022
@iritkatriel iritkatriel mentioned this pull request Jul 21, 2022
direct unit tests for compiler optimisations faster-cpython/ideas#405
Closed
iritkatriel added 3 commits July 24, 2022 21:04
@iritkatriel
add entryblock field to cfg struct
7984b09
@iritkatriel
remove basicblock_new_b_list_successor and use cfg_new_block instead
43fa292
@iritkatriel
inline new_basicblock - it's called in onyl one place now and it's no…
1e7d1df 
…t safe to call from elsewhere
markshannon
markshannon reviewed Jul 25, 2022
View reviewed changes

@markshannon markshannon left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One question

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread Python/compile.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
@iritkatriel iritkatriel removed the skip news label Jul 25, 2022
@iritkatriel
rename cfg --> cfg_builder, entryblock field --> cfg
e943cc2
@iritkatriel iritkatriel changed the title gh-93678: extract 'struct cfg' from the compiler so that the CFG can be manipulated directly gh-93678: extract 'struct cfg_builder' from the compiler so that the CFG can be manipulated directly Jul 26, 2022
blurb-it Bot and others added 4 commits July 26, 2022 09:31
@blurb-it
📜🤖 Added by blurb_it.
f7ba9e8
@iritkatriel
Merge branch 'main' into cfg_struct
c3e767a
@iritkatriel
cfg --> cfg_entryblock
5a6dc5d
@iritkatriel
remove obsolete comment
3a8436e
@iritkatriel

iritkatriel commented Jul 26, 2022

Copy link
Copy Markdown
Member Author

@markshannon Any more comments on this?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
markshannon
markshannon approved these changes Jul 26, 2022
View reviewed changes

@markshannon markshannon left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FTR, I'd prefer we pass locations by value, but no need to do that for this PR.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting core review labels Jul 26, 2022
@iritkatriel
pass location by value
873d34f
@iritkatriel

iritkatriel commented Jul 26, 2022

Copy link
Copy Markdown
Member Author

FTR, I'd prefer we pass locations by value, but no need to do that for this PR.

Sure, might as well do it here.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@iritkatriel
iritkatriel merged commit 75c0c1b into python:main Jul 26, 2022
@bedevere-bot bedevere-bot removed the awaiting merge label Jul 26, 2022
@iritkatriel
iritkatriel deleted the cfg_struct branch July 26, 2022 13:36
@iritkatriel iritkatriel mentioned this pull request Jul 27, 2022
test_compiler_recursion_limit fails on wasm32-wasi #95335
Closed
@iritkatriel iritkatriel changed the title gh-93678: extract 'struct cfg_builder' from the compiler so that the CFG can be manipulated directly gh-95335: extract 'struct cfg_builder' from the compiler so that the CFG can be manipulated directly Jul 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@markshannon markshannon markshannon approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

interpreter-core (Objects, Python, Grammar, and Parser dirs)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@iritkatriel @bedevere-bot @markshannon
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.