GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-95377: Editted docs for argparse.add_subparser by PurityLake · Pull Request #95490 · python/cpython

Conversation

@PurityLake

@PurityLake PurityLake commented Jul 31, 2022 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Relates to #95377

Added documentation to make it clear that required parameter requires dest parameter inf argparse.add_subparser

  • Issue: Incorrect information in add_subparser() docs.  #95377

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-bot bedevere-bot added awaiting review docs Documentation in the Doc dir labels Jul 31, 2022
@PurityLake
PurityLake force-pushed the add-docs-95377 branch from 3bb4bf4 to e9f7a26 Compare July 31, 2022 13:41
@PurityLake
pythongh-95377: Editted docs for argparse
ce36799
@PurityLake
PurityLake force-pushed the add-docs-95377 branch from e9f7a26 to ce36799 Compare August 5, 2022 14:23
iritkatriel
iritkatriel reviewed Aug 14, 2022
View reviewed changes
Comment thread Doc/library/argparse.rst Outdated
* dest_ - name of the attribute under which sub-command name will be
stored; by default ``None`` and no value is stored
stored; by default ``None`` and no value is stored. Required if
required_ has been passed

@iritkatriel iritkatriel Aug 14, 2022

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

‘Required if required’ doesn’t read well.

maybe just remove this addition. Is it not enough to document this under ‘required’?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@PurityLake PurityLake Dec 24, 2022

Copy link
Copy Markdown
Contributor Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies for the radio silence, I have removed the line as requested, as yes it isn't needed

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
PurityLake added 2 commits August 27, 2022 02:53
@PurityLake
Merge branch 'python:main' into add-docs-95377
2de027d
@PurityLake
Merge branch 'python:main' into add-docs-95377
e691341
@bedevere-bot bedevere-bot mentioned this pull request Dec 24, 2022
Incorrect information in add_subparser() docs. #95377
Closed
PurityLake and others added 2 commits December 24, 2022 00:49
@PurityLake
pythongh-95377: Removed unnessecary line in argpase.rst
1892cfe
@PurityLake
Merge branch 'main' into add-docs-95377
3f4f230
cougargt
cougargt approved these changes Feb 5, 2023
View reviewed changes

@cougargt cougargt left a comment

Copy link
Copy Markdown

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor revisions to argparse inline comments.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-bot bedevere-bot added awaiting core review and removed awaiting review labels Feb 5, 2023
@PurityLake
PurityLake requested a review from iritkatriel February 22, 2023 16:58
@PurityLake PurityLake changed the title gh-95377: Editted docs for argparse.add._subparser gh-95377: Editted docs for argparse.add_subparser Feb 25, 2023
@PurityLake
Merge branch 'main' into add-docs-95377
c0cc077
@PurityLake PurityLake closed this Mar 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iritkatriel iritkatriel Awaiting requested review from iritkatriel
1 more reviewer
@cougargt cougargt cougargt approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

awaiting core review docs Documentation in the Doc dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@PurityLake @iritkatriel @cougargt @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.