GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — GH-95245: Move weakreflist into the pre-header. by markshannon · Pull Request #95996 · python/cpython

Conversation

@markshannon

@markshannon markshannon commented Aug 15, 2022 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

A more robust version of #95657 that allows third party code to have managed weakrefs.

  • Issue: Reduce the size of plain Python objects from 8 to 6 machine words. #95245

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
markshannon added 5 commits August 15, 2022 12:31
@markshannon
Add managed weakref flag.
de6f4e2
@markshannon
Move weakreflist to preheader
5724717
@markshannon
Add news
73ac380
@markshannon
Fix comments.
9b06314
@markshannon
Add tests for managed weakrefs.
5ecb5be
@bedevere-bot bedevere-bot added the awaiting core review label Aug 15, 2022
@markshannon markshannon mentioned this pull request Aug 15, 2022
GH-95245: Move weakreflist into the pre-header. #95657
Closed
@markshannon
Merge branch 'main' into move-weakref-to-preheader-2
74030ef
@ericsnowcurrently
ericsnowcurrently self-requested a review August 15, 2022 16:04
ericsnowcurrently
ericsnowcurrently requested changes Aug 15, 2022
View reviewed changes

@ericsnowcurrently ericsnowcurrently left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly LGTM (a few minor comments)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread Lib/test/test_capi.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Include/internal/pycore_object.h Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Include/internal/pycore_object.h Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Objects/typeobject.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the awaiting core review label Aug 15, 2022
@bedevere-bot

bedevere-bot commented Aug 15, 2022

Copy link
Copy Markdown

When you're done making the requested changes, leave the comment: I have made the requested changes; please review again.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot added the awaiting changes label Aug 15, 2022
markshannon added 2 commits August 16, 2022 09:50
@markshannon
Apply Eric Snow's suggestions.
ba4971b
@markshannon
Avoid cycle when testing weakref.
0dedf78
@markshannon markshannon added 🔨 test-with-buildbots Test PR w/ buildbots; report in status section and removed awaiting changes labels Aug 16, 2022
@bedevere-bot

bedevere-bot commented Aug 16, 2022

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @markshannon for commit 0dedf78 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Aug 16, 2022
@markshannon
markshannon merged commit 5a8c158 into python:main Aug 16, 2022
@markshannon
markshannon deleted the move-weakref-to-preheader-2 branch September 26, 2023 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ericsnowcurrently ericsnowcurrently ericsnowcurrently requested changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@markshannon @bedevere-bot @ericsnowcurrently
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.