GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Close sub-generators even if top level generator was asynchronous. by markshannon · Pull Request #96040 · python/cpython

Conversation

@markshannon

@markshannon markshannon commented Aug 17, 2022

Copy link
Copy Markdown
Member

I think this is correct.
It seems odd that whether a sub-generator is closed or not depends on whether an async generator exists higher up the stack.

@brandtbucher thoughts?

Will need news and issue, if we agree this is correct.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@markshannon
Close sub-generators even if top level generator was asynchronous.
fe7a0b1
@markshannon markshannon added the skip news label Aug 17, 2022
@bedevere-bot bedevere-bot added the awaiting core review label Aug 17, 2022
@markshannon markshannon added the skip issue label Aug 17, 2022
@markshannon
markshannon requested a review from brandtbucher August 17, 2022 10:49
@markshannon markshannon mentioned this pull request Aug 17, 2022
GH-90997: Wrap yield from/await in a virtual try/except StopIteration #96010
Merged
brandtbucher
brandtbucher reviewed May 10, 2023
View reviewed changes

@brandtbucher brandtbucher left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Has this been abandoned, or are you still considering it for 3.13? I agree that this makes the code a bit simpler, but I find it hard to reason about whether the correctness is preserved or not (presumably there's some reason it currently works this way).

So I would lean towards not changing it, unless we have a compelling reason to.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@markshannon markshannon closed this Aug 6, 2024
@markshannon
markshannon deleted the remove-close-on-genexit branch August 6, 2024 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@brandtbucher brandtbucher brandtbucher left review comments

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

awaiting core review skip issue skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@markshannon @brandtbucher @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.