GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-90110: Update the c-analyzer Tool by ericsnowcurrently · Pull Request #96255 · python/cpython

Conversation

@ericsnowcurrently

@ericsnowcurrently ericsnowcurrently commented Aug 25, 2022 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Here we automatically ignore uses of _PyArg_Parser, "kwlist" arrays, and module/type defs. That way new uses don't trigger false positives in the c-analyzer check script.

  • Issue: Tools/c-analyzer is out-of-date. #90110

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
ericsnowcurrently added 11 commits August 24, 2022 14:14
@ericsnowcurrently
Fix an undefined variable.
a6a3360
@ericsnowcurrently
Fix a moved variable.
e5253e5
@ericsnowcurrently
Treat all _PyArg_Parser as supported.
e9298d6
@ericsnowcurrently
Treat other "immutable" structs as supported.
7593110
@ericsnowcurrently
Factor out _has_other_supported_type().
0d2db68
@ericsnowcurrently
Add some ignored vars back in.
f2c3ec4
@ericsnowcurrently
Ignore "mutable" vars with supported types.
5c585c7
@ericsnowcurrently
Marks some globals to fix.
bc9abe8
@ericsnowcurrently
Manually ignore globals that the analyzer should have ignored.
6947e82
@ericsnowcurrently
Ignore globals that look like a kwlist array.
0d6c58f
@ericsnowcurrently
Add some notes about auto-ignored vars.
531bf22
@ericsnowcurrently ericsnowcurrently added the skip news label Aug 25, 2022
@ericsnowcurrently
ericsnowcurrently requested review from abalkin and pganssle as code owners August 25, 2022 01:00
@bedevere-bot bedevere-bot added the awaiting core review label Aug 25, 2022
@ericsnowcurrently
ericsnowcurrently removed request for abalkin and pganssle August 25, 2022 01:01
@ericsnowcurrently
Do not normalize any variable names.
e880092
@ericsnowcurrently
ericsnowcurrently merged commit d45d5c2 into python:main Aug 25, 2022
@bedevere-bot bedevere-bot removed the awaiting core review label Aug 25, 2022
@ericsnowcurrently
ericsnowcurrently deleted the update-c-analyzer branch August 25, 2022 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@ericsnowcurrently @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.