GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | ||||||||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | ||||||||||
GeezerVison is showing github.com — Update download.html to reflect the unit change by andresdelfino · Pull Request #9639 · python/cpython Conversation
|
|
@JulienPalard: Would you mind to review this PR? |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
@JulienPalard could you take a look at this? |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
|
An alternative is to remove the download sizes. I don't expect that release managers update this page as part of the release process: |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
I also think that documentation size isn't that important nowadays, but perhaps there's a rationale we are missing here? |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
@andresdelfino there are regions here in germany where people only get very slow internet connections. So it makes a difference for them if it is 1 MB or 5 MB. But they might not be python developers... |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
@vstinner how should I proceed? Should I remove the file sizes or preserve them and fix the typo pointed by Serhiy? |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
@andresdelfino: Honestly, I'm very confused by this issue. I don't understand why it takes months to fix such trivial issue :-) I skip my turn and let others handle it, sorry :-( |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
|
With the commit of @vstinner (see 8c663fd#diff-9c9d6c705ef5234b89019a8310a89d21), we don't need to specify the unit because it's explicitly indicated in the table. Moreover, the commit removes the ambiguity with the unit. The best thing to do is removing the complete line with the detailed unit. I am going to close your PR and will fix the line. Thank you a lot for your PR and hope to see your next contributions in the future. PS: Before closing this issue, I have discussed with @JulienPalard about this issue. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
@matrixise thanks for the reply :) |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
@matrixise: Would you mind to add a link to your fix here? |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
Successfully merging this pull request may close these issues.
There was an error while loading. Please reload this page.