GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Update download.html to reflect the unit change by andresdelfino · Pull Request #9639 · python/cpython

Conversation

@andresdelfino

@andresdelfino andresdelfino commented Sep 29, 2018 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

See #4293.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@andresdelfino
Update download.html
87a2474
@bedevere-bot bedevere-bot added the awaiting review label Sep 29, 2018
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Sep 29, 2018
davidak
davidak approved these changes Nov 1, 2018
View reviewed changes
@bedevere-bot bedevere-bot added awaiting core review and removed awaiting review labels Nov 1, 2018
@serhiy-storchaka serhiy-storchaka added docs Documentation in the Doc dir skip issue skip news labels Nov 7, 2018
@serhiy-storchaka
serhiy-storchaka requested a review from vstinner November 7, 2018 18:14
vstinner
vstinner reviewed Nov 7, 2018
View reviewed changes
Comment thread Doc/tools/templates/download.html Resolved

Uh oh!

There was an error while loading. Please reload this page.

@andresdelfino
Address comment from Victor
38dde7d
vstinner
vstinner approved these changes Nov 7, 2018
View reviewed changes

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting core review labels Nov 7, 2018
@vstinner

vstinner commented Nov 7, 2018

Copy link
Copy Markdown
Member

@JulienPalard: Would you mind to review this PR?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@andresdelfino

andresdelfino commented Feb 23, 2019

Copy link
Copy Markdown
Contributor Author

@JulienPalard could you take a look at this?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

serhiy-storchaka
serhiy-storchaka reviewed Feb 23, 2019
View reviewed changes
Comment thread Doc/tools/templates/download.html Resolved

Uh oh!

There was an error while loading. Please reload this page.

@vstinner

vstinner commented Feb 25, 2019

Copy link
Copy Markdown
Member

An alternative is to remove the download sizes. I don't expect that release managers update this page as part of the release process:
https://www.python.org/dev/peps/pep-0101/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@andresdelfino

andresdelfino commented Feb 26, 2019

Copy link
Copy Markdown
Contributor Author

An alternative is to remove the download sizes. I don't expect that release managers update this page as part of the release process:
https://www.python.org/dev/peps/pep-0101/

I also think that documentation size isn't that important nowadays, but perhaps there's a rationale we are missing here?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@davidak

davidak commented Feb 26, 2019

Copy link
Copy Markdown
Contributor

@andresdelfino there are regions here in germany where people only get very slow internet connections. So it makes a difference for them if it is 1 MB or 5 MB. But they might not be python developers...

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@andresdelfino

andresdelfino commented Mar 2, 2019

Copy link
Copy Markdown
Contributor Author

@davidak thanks for the insight!

@vstinner I'd keep the file sizes. Let me know how do you want to proceed on this one and I'll update the PR.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@andresdelfino

andresdelfino commented Mar 26, 2019

Copy link
Copy Markdown
Contributor Author

@vstinner how should I proceed? Should I remove the file sizes or preserve them and fix the typo pointed by Serhiy?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@vstinner

vstinner commented Mar 27, 2019

Copy link
Copy Markdown
Member

@andresdelfino: Honestly, I'm very confused by this issue. I don't understand why it takes months to fix such trivial issue :-) I skip my turn and let others handle it, sorry :-(

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@andresdelfino
Address comment from Serhiy
3c15842
@matrixise
matrixise requested a review from JulienPalard May 6, 2019 17:19
@matrixise

matrixise commented May 6, 2019 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

With the commit of @vstinner (see 8c663fd#diff-9c9d6c705ef5234b89019a8310a89d21), we don't need to specify the unit because it's explicitly indicated in the table.

Moreover, the commit removes the ambiguity with the unit.

The best thing to do is removing the complete line with the detailed unit.

I am going to close your PR and will fix the line.

Thank you a lot for your PR and hope to see your next contributions in the future.

PS: Before closing this issue, I have discussed with @JulienPalard about this issue.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@matrixise matrixise closed this May 6, 2019
@andresdelfino
andresdelfino deleted the patch-3 branch May 6, 2019 17:51
@andresdelfino

andresdelfino commented May 6, 2019

Copy link
Copy Markdown
Contributor Author

@matrixise thanks for the reply :)

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@vstinner

vstinner commented May 10, 2019

Copy link
Copy Markdown
Member

The best thing to do is removing the complete line with the detailed unit. I am going to close your PR and will fix the line.

@matrixise: Would you mind to add a link to your fix here?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@serhiy-storchaka serhiy-storchaka serhiy-storchaka left review comments
@vstinner vstinner vstinner approved these changes
@JulienPalard JulienPalard Awaiting requested review from JulienPalard
+1 more reviewer
@davidak davidak davidak approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

awaiting merge docs Documentation in the Doc dir skip issue skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

7 participants

@andresdelfino @vstinner @davidak @matrixise @serhiy-storchaka @the-knights-who-say-ni @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.