GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-96143: Add some comments and minor fixes missed in the original PR by pablogsal · Pull Request #96433 · python/cpython

Conversation

@pablogsal

@pablogsal pablogsal commented Aug 30, 2022 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Automerge-Triggered-By: GH:pablogsal

  • Issue: Allow the linux perf profiler to see Python calls #96143

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@pablogsal
pythongh-96132: Add some comments and minor fixes missed in the origi…
a29c184 
…nal PR
@bedevere-bot bedevere-bot added the awaiting core review label Aug 30, 2022
@pablogsal pablogsal mentioned this pull request Aug 30, 2022
gh-96143: Allow Linux perf profiler to see Python calls #96123
Merged
@pablogsal pablogsal added the 🤖 automerge label Aug 30, 2022
@pablogsal pablogsal changed the title gh-96132: Add some comments and minor fixes missed in the original PR gh-96143: Add some comments and minor fixes missed in the original PR Aug 30, 2022
@pablogsal pablogsal added the skip news label Aug 30, 2022
kumaraditya303
kumaraditya303 reviewed Aug 30, 2022
View reviewed changes
Comment thread Doc/using/cmdline.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
@pablogsal @kumaraditya303
Update Doc/using/cmdline.rst
fea741d 
Co-authored-by: Kumar Aditya <[email protected]>
kumaraditya303
kumaraditya303 reviewed Aug 30, 2022
View reviewed changes
Comment thread Objects/perf_trampoline.c
}
// Some systems may prevent us from creating executable code on the fly.
// TODO: Call icache invalidation intrinsics if available:
// __builtin___clear_cache/__clear_cache (depending if clang/gcc). This is

@kumaraditya303 kumaraditya303 Aug 30, 2022

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The kernel would clear the icache for us. Not sure if this would ever be a problem.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@pablogsal pablogsal Aug 30, 2022

Copy link
Copy Markdown
Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's not correct in the general case. You are supposed to call this in aarch64 if you modify the code in some executable segment after it was read at least once. This doesn't apply for us but is not true that in all systems the kernel will clear it for us

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@pablogsal pablogsal Aug 30, 2022

Copy link
Copy Markdown
Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the discussion in the previous pr

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
kumaraditya303 reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@pablogsal
pablogsal merged commit f49dd54 into python:main Aug 30, 2022
@pablogsal
pablogsal deleted the gh-96143 branch August 30, 2022 18:37
@bedevere-bot bedevere-bot removed the awaiting core review label Aug 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kumaraditya303 kumaraditya303 kumaraditya303 left review comments

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@pablogsal @kumaraditya303 @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.