GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-96143: subprocess API %s/universal_newlines=/text=/g. by gpshead · Pull Request #96468 · python/cpython

Conversation

@gpshead

@gpshead gpshead commented Sep 1, 2022 •
edited by miss-islington
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

minor missed test cleanup to use the modern API from the big review.

  • Issue: Allow the linux perf profiler to see Python calls #96143

Automerge-Triggered-By: GH:gpshead

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@gpshead
subprocess API %s/universal_newlines=/text=/g.
e99b176
@gpshead gpshead added tests Tests in the Lib/test dir skip news labels Sep 1, 2022
@bedevere-bot bedevere-bot added the awaiting core review label Sep 1, 2022
@gpshead gpshead added the 🤖 automerge label Sep 1, 2022
@gpshead
gpshead requested a review from pablogsal September 1, 2022 00:16
pablogsal
pablogsal approved these changes Sep 1, 2022
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting core review labels Sep 1, 2022
@miss-islington
miss-islington merged commit e93d1bd into python:main Sep 1, 2022
@bedevere-bot bedevere-bot removed the awaiting merge label Sep 1, 2022
@pablogsal

pablogsal commented Sep 1, 2022

Copy link
Copy Markdown
Member

Thanks @gpshead and apologies for missing this!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pablogsal pablogsal pablogsal approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@gpshead @pablogsal @bedevere-bot @miss-islington
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.