GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | |||||||||||||||||||||||||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | |||||||||||||||||||||||||||
GeezerVison is showing github.com — gh-96471: Add queue shutdown by EpicWink · Pull Request #96474 · python/cpython Conversation
|
|
Most changes to Python require a NEWS entry. Please add it using the blurb_it web app or the blurb command-line tool. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Note that once this is ready for review we may need three separate reviewers -- one for asyncio, another for multiprocessing, a third for threading. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
| Put an item into the queue. If the queue is full, wait until a free | ||
| slot is available before adding item. | ||
| """ | ||
| if self.shutdown_state != _queue_alive: |
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
an example:
| if self.shutdown_state != _queue_alive: | |
| if self.shutdown_state is not _QueueState.ALIVE: |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
|
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
This should help: https://devguide.python.org/getting-started/git-boot-camp/ The basic commands you will need are |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
@merwok Thank for your feedback. I created my own branch from EpicWink:queue-shutdown, and I am wondering how to give access to my changes. So may be @EpicWink can merge from YvesDup:queue-shutdown ? |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Oh I missed that you weren’t the author of the PR! Yes, you can make a pull request from your fork to epicwink’s work, or use the suggestion system here (comment on a line, find suggestion in the toolbar) to paste your new tests. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
I read again the original topic and found nothing about what to do about the 'joined' tasks, threads (or processes). I just complete the |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
@YvesDup What is your definition of a "'joined' task or thread"? |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
|
@gvanrossum: Task (or thread) that has called the |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
Co-authored-by: Duprat <[email protected]>
Co-authored-by: Duprat <[email protected]>
Co-authored-by: Duprat <[email protected]>
|
I'm reviewing @YvesDup 's changes in EpicWink#2 |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
I have just created a new PR gh-96471: Add queue shutdown, next step. to resume and continue working on this feature |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
Successfully merging this pull request may close these issues.
There was an error while loading. Please reload this page.