GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-96143: Clear instruction cache after mprotect call by pablogsal · Pull Request #96476 · python/cpython

Conversation

@pablogsal

@pablogsal pablogsal commented Sep 1, 2022 •
edited by miss-islington
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • Issue: Allow the linux perf profiler to see Python calls #96143

Automerge-Triggered-By: GH:pablogsal

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@pablogsal
pythongh-96143: Clear instruction cache after mprotect call
e000d0e
@pablogsal pablogsal added the skip news label Sep 1, 2022
@pablogsal
pablogsal requested a review from gpshead September 1, 2022 12:14
@bedevere-bot bedevere-bot added the awaiting core review label Sep 1, 2022
@pablogsal pablogsal added the 🤖 automerge label Sep 1, 2022
vstinner
vstinner reviewed Sep 1, 2022
View reviewed changes
Comment thread Objects/perf_trampoline.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
vstinner
vstinner reviewed Sep 1, 2022
View reviewed changes
Comment thread Objects/perf_trampoline.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
@pablogsal
Add a bunch of macros
33e10bf 
Signed-off-by: Pablo Galindo <[email protected]>
@pablogsal
pablogsal force-pushed the gh-96143-2 branch from ecafc46 to 33e10bf Compare September 1, 2022 16:30
vstinner
vstinner reviewed Sep 2, 2022
View reviewed changes

@vstinner vstinner left a comment •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI libffi had/has a similar issue on ARM with SELinux: https://bugzilla.redhat.com/show_bug.cgi?id=1652930

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
gpshead reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
Comment thread Objects/perf_trampoline.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
pablogsal
pablogsal commented Sep 2, 2022
View reviewed changes
Comment thread Objects/perf_trampoline.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
@pablogsal
Update Objects/perf_trampoline.c
fefcef3
@pablogsal
pablogsal merged commit 3fedfcf into python:main Sep 8, 2022
@pablogsal
pablogsal deleted the gh-96143-2 branch September 8, 2022 11:04
@bedevere-bot bedevere-bot removed the awaiting core review label Sep 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner vstinner left review comments
@gpshead gpshead Awaiting requested review from gpshead

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@pablogsal @vstinner @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.