GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — GH-96465: Cache hashes for Fraction instances by rhettinger · Pull Request #96483 · python/cpython

Conversation

@rhettinger

@rhettinger rhettinger commented Sep 1, 2022 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor
  • Issue: Cache the hash value of fractions #96465

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@rhettinger
pythonGH-96465: Cache hashes for Fraction instances
12a17c6
@rhettinger rhettinger added the performance Performance or resource usage label Sep 1, 2022
@bedevere-bot bedevere-bot added the awaiting core review label Sep 1, 2022
matthiasgoergens
matthiasgoergens reviewed Sep 6, 2022
View reviewed changes
Comment thread Lib/fractions.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
@rhettinger
rhettinger merged commit 3eaf70d into python:main Sep 7, 2022
@bedevere-bot bedevere-bot removed the awaiting core review label Sep 7, 2022
@zware zware mentioned this pull request Sep 8, 2022
gh-96465: Clear fractions hash lru_cache under refleak testing #96689
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@matthiasgoergens matthiasgoergens matthiasgoergens left review comments
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

performance Performance or resource usage

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@rhettinger @matthiasgoergens @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.