GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.11] GH-96636: Remove all uses of NOTRACE_DISPATCH (GH-96643) by markshannon · Pull Request #96688 · python/cpython

Conversation

@markshannon

@markshannon markshannon commented Sep 8, 2022 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Co-authored-by: Brandt Bucher [email protected]
(cherry picked from commit aa3b4cf)

  • Issue: NOTRACE_DISPATCH breaks tracing #96636

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
markshannon and others added 2 commits September 8, 2022 17:34
@markshannon @brandtbucher
pythonGH-96636: Remove all uses of NOTRACE_DISPATCH (pythonGH-96643)
c3e987b 
Co-authored-by: Brandt Bucher <[email protected]>
(cherry picked from commit aa3b4cf)
@markshannon
Remove merge artiifacts.
993bf61
@bedevere-bot bedevere-bot added the awaiting core review label Sep 8, 2022
@markshannon markshannon changed the title GH-96636: Remove all uses of NOTRACE_DISPATCH (GH-96643) [3.11] GH-96636: Remove all uses of NOTRACE_DISPATCH (GH-96643) Sep 8, 2022
@bedevere-bot bedevere-bot mentioned this pull request Sep 8, 2022
GH-96636: Remove all uses of NOTRACE_DISPATCH #96643
Merged
gvanrossum
gvanrossum approved these changes Sep 8, 2022
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting core review labels Sep 8, 2022
@gvanrossum

gvanrossum commented Sep 8, 2022

Copy link
Copy Markdown
Member

Whoops this probably should wait for @pablogsal before it gets merged.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@markshannon

markshannon commented Sep 9, 2022

Copy link
Copy Markdown
Member Author

@pablogsal?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
pablogsal
pablogsal approved these changes Sep 9, 2022
View reviewed changes
@pablogsal

pablogsal commented Sep 9, 2022

Copy link
Copy Markdown
Member

It would be great if we can quickly check that the coverage test suite passes or doesn't fail more with this PR before landing.

Otherwise, LGTM, land when ready 👍
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@markshannon

markshannon commented Sep 9, 2022

Copy link
Copy Markdown
Member Author

This shouldn't impact coverage.py. This is for weird code that turns on tracing in finalizers, weakrefs or asynchronously.

I'm fairly sure coverage.py doesn't do any of those things. @nedbat?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nedbat

nedbat commented Sep 9, 2022

Copy link
Copy Markdown
Member

Coverage.py doesn't do any of those weird things :) Also, I now have nightly build testing every day, so we'll hear soon if this broke something.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@pablogsal

pablogsal commented Sep 9, 2022

Copy link
Copy Markdown
Member

Ok, let's merge it then 👍
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@gvanrossum
gvanrossum merged commit 5586da6 into python:3.11 Sep 9, 2022
@bedevere-bot bedevere-bot removed the awaiting merge label Sep 9, 2022
@gvanrossum
gvanrossum deleted the backport-aa3b4cf-3.11 branch September 9, 2022 16:24
@neonene

neonene commented Sep 21, 2022

Copy link
Copy Markdown
Contributor

An extra DISPATCH() macro has been added accidentally, which has no harm.

cpython/Python/ceval.c

Lines 3582 to 3586 in 46f791d

DISPATCH();
}
DISPATCH();
TARGET(STORE_ATTR_ADAPTIVE) {

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@brandtbucher

brandtbucher commented Sep 21, 2022

Copy link
Copy Markdown
Member

Nice catch. I'll open a PR to fix.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gvanrossum gvanrossum gvanrossum approved these changes
@pablogsal pablogsal pablogsal approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

7 participants

@markshannon @gvanrossum @pablogsal @nedbat @neonene @brandtbucher @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.