GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-90110: Fix the c-analyzer Tool by ericsnowcurrently · Pull Request #96731 · python/cpython

Conversation

@ericsnowcurrently

@ericsnowcurrently ericsnowcurrently commented Sep 10, 2022 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

This includes:

  • update the whitelists
  • fixes so we can stop ignoring some of the files
  • ensure Include/cpython/*.h get analyzed
  • Issue: Tools/c-analyzer is out-of-date. #90110

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
ericsnowcurrently added 25 commits September 9, 2022 15:55
@ericsnowcurrently
Add large, ignored files to MAX_SIZES.
f93e2c6
@ericsnowcurrently
Fixups for Python/thread_pthread.h.
a8bd590
@ericsnowcurrently
Add some missing defines.
683d1ba
@ericsnowcurrently
Support passing "includes" to preprocess().
dd8b682
@ericsnowcurrently
Update parser data.
1b822b7
@ericsnowcurrently
Fix whitelists.
42114c0
@ericsnowcurrently
Stop ignoring cjkcodecs.
342ccee
@ericsnowcurrently
Stop ignoring _dbmmodule.c.
12fc111
@ericsnowcurrently
Stop ignoring stringlib.
1f82c05
@ericsnowcurrently
Add a TODO.
6e67f68
@ericsnowcurrently
Fix perf_trampoline.c.
5c898c4
@ericsnowcurrently
Stop ignoring hashlib.h.
b930efa
@ericsnowcurrently
Fix thread_pthread_stubs.h.
c74b308
@ericsnowcurrently
Stop ignoring KeccakP-1600-opt64.c.
7296153
@ericsnowcurrently
Add a note about maybe-inline-actual.
9566436
@ericsnowcurrently
Add c_common.fsutil.match_path_tail().
f91b6d7
@ericsnowcurrently
Do not add the current file as an include.
28d5cc5
@ericsnowcurrently
Update gcc.preprocess().
2fa3d87
@ericsnowcurrently
Always print the current filename when c_parser.parse_files() fails.
401bd73
@ericsnowcurrently
Use a consistent filename variable name.
fc3a5a5
@ericsnowcurrently
Always use absolute paths.
917a099
@ericsnowcurrently
Stop filtering includes.
13449a9
@ericsnowcurrently
Fix analysis for typeobject.c.
c7050eb
@ericsnowcurrently
Ignore pystate.c:initial.
07a87cb
@ericsnowcurrently
Fix "samefiles" handling.
d1d725e
@ericsnowcurrently ericsnowcurrently added the skip news label Sep 10, 2022
@bedevere-bot bedevere-bot added the awaiting core review label Sep 10, 2022
chalggg
chalggg reviewed Sep 11, 2022
View reviewed changes
Comment thread Tools/c-analyzer/c_parser/preprocessor/__init__.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
@ericsnowcurrently
Report the correct CWD in verbose output.
6a0e7fc
kumaraditya303
kumaraditya303 approved these changes Sep 12, 2022
View reviewed changes

@kumaraditya303 kumaraditya303 left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! The number of static globals are decreasing steadily.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@ericsnowcurrently
ericsnowcurrently merged commit 1756ffd into python:main Sep 12, 2022
@bedevere-bot bedevere-bot removed the awaiting core review label Sep 12, 2022
@ericsnowcurrently
ericsnowcurrently deleted the fix-c-analyzer branch September 12, 2022 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kumaraditya303 kumaraditya303 kumaraditya303 approved these changes
+1 more reviewer
@chalggg chalggg chalggg left review comments
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@ericsnowcurrently @chalggg @kumaraditya303 @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.