GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-94808: Improve coverage of fastsearch.h by sweeneyde · Pull Request #96760 · python/cpython

Conversation

@sweeneyde

@sweeneyde sweeneyde commented Sep 12, 2022 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • Issue: Metabug: Improving C-level coverage #94808

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@sweeneyde
improve comments and coverage of fastsearch.h
84999e6
@sweeneyde sweeneyde added tests Tests in the Lib/test dir skip news labels Sep 12, 2022
@bedevere-bot bedevere-bot added the awaiting core review label Sep 12, 2022
@sweeneyde

sweeneyde commented Sep 12, 2022

Copy link
Copy Markdown
Member Author

This doesn't touch find_char or rfind_char, whose coverage could be improved in a separate PR.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@sweeneyde

sweeneyde commented Sep 13, 2022

Copy link
Copy Markdown
Member Author

Hitting this with the buildbots to make sure the new tests don't provoke anything.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@sweeneyde sweeneyde added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Sep 13, 2022
@bedevere-bot

bedevere-bot commented Sep 13, 2022

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @sweeneyde for commit 84999e6 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Sep 13, 2022
@mdboom mdboom mentioned this pull request Sep 13, 2022
Metabug: Improving C-level coverage #94808
Open
@sweeneyde
sweeneyde merged commit 69d9a08 into python:main Sep 13, 2022
@bedevere-bot bedevere-bot removed the awaiting core review label Sep 13, 2022
@sweeneyde
sweeneyde deleted the cover_fastsearch branch September 13, 2022 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@sweeneyde @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.