GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-34875: change .js mimetype to text/javascript by MylesBorins · Pull Request #9678 · python/cpython

Conversation

@MylesBorins

@MylesBorins MylesBorins commented Oct 2, 2018 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

Follow up to #3908

The official recommended mime type of .js in the whatwg HTML spec is "text/javascript" as opposed to "application/javascript" which is what is currently shipping

https://bugs.python.org/issue34875

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
bricss and mathiasbynens reacted with thumbs up emoji
All reactions
  • 👍 2 reactions
@MylesBorins
bpo-34875: change .js mimetype to text/javascript
87ecd84
@MylesBorins
MylesBorins requested a review from a team as a code owner October 2, 2018 22:39
@bedevere-bot bedevere-bot added the awaiting review label Oct 2, 2018
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Oct 2, 2018
@MylesBorins MylesBorins mentioned this pull request Oct 2, 2018
bpo-31715 Add mimetype for extension .mjs #3908
Merged
@MylesBorins
fixup: remove :javascript from news
69b3976
ezio-melotti
ezio-melotti reviewed Oct 2, 2018
View reviewed changes
Comment thread Misc/NEWS.d/next/Library/2018-10-02-18-33-30.bpo-34875.8Js9dJ.rst Outdated
@@ -0,0 +1,3 @@
Change mimetype for file extension ``.js`` to ``test/javascript``. This is currently the recommended mimetype in the whatwg HTML spec

@ezio-melotti ezio-melotti Oct 2, 2018

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/test/text/

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@MylesBorins
fixup: fix speeling errror
89212c7
@asvetlov

asvetlov commented Oct 3, 2018

Copy link
Copy Markdown
Contributor

The reason for rejecting is described in the bug tracker: https://bugs.python.org/issue34875
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@asvetlov asvetlov closed this Oct 3, 2018
@MylesBorins MylesBorins mannequin mentioned this pull request May 10, 2022
Change .js mime to "text/javascript" #79056
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ezio-melotti ezio-melotti ezio-melotti left review comments

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

awaiting review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@MylesBorins @asvetlov @ezio-melotti @the-knights-who-say-ni @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.