GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.11] gh-97527: IDLE: protect macosx Tk() call when no GUI (GH-97530) by miss-islington · Pull Request #97531 · python/cpython

Conversation

@miss-islington

@miss-islington miss-islington commented Sep 24, 2022 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Only call tkinter.tk and its follow-up code in _init_tk_type when requires('gui')
does not raise. This function can be called as an unintended side-effect of
calling other idlelib code as part of tests on macOS without a GUI enabled.
(cherry picked from commit 9704f8d)

Co-authored-by: Terry Jan Reedy [email protected]

  • Issue: IDLE: protect macOS Tk() call when no GUI #97527

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@terryjreedy @miss-islington
pythongh-97527: IDLE: protect macosx Tk() call when no GUI (pythonGH-…
e2154d9
…97530)

Only call tkinter.tk and its follow-up code in _init_tk_type when requires('gui')
does not raise.  This function can be called as an unintended side-effect of
calling other idlelib code as part of tests on macOS without a GUI enabled.
(cherry picked from commit 9704f8d)

Co-authored-by: Terry Jan Reedy <[email protected]>
@miss-islington
miss-islington requested a review from terryjreedy as a code owner September 24, 2022 21:39
@bedevere-bot bedevere-bot mentioned this pull request Sep 24, 2022
gh-97527: IDLE: protect macosx Tk() call when no GUI #97530
Merged
@bedevere-bot bedevere-bot added skip news awaiting review labels Sep 24, 2022
terryjreedy
terryjreedy approved these changes Sep 24, 2022
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting review labels Sep 24, 2022
@miss-islington

miss-islington commented Sep 24, 2022

Copy link
Copy Markdown
Contributor Author

Status check is done, and it's a success ✅.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@miss-islington
miss-islington merged commit fe8db63 into python:3.11 Sep 24, 2022
@bedevere-bot bedevere-bot removed the awaiting merge label Sep 24, 2022
@miss-islington
miss-islington deleted the backport-9704f8d-3.11 branch September 24, 2022 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@terryjreedy terryjreedy terryjreedy approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@miss-islington @terryjreedy @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.