GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.11] GH-65046: Fix docs about logging in `asyncio` (GH-97559) by miss-islington · Pull Request #97582 · python/cpython

Conversation

@miss-islington

@miss-islington miss-islington commented Sep 26, 2022 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Explain that logging should not use network I/O.
(cherry picked from commit d68c37c)

Co-authored-by: Kumar Aditya [email protected]

  • Issue: asyncio docs should call out that network logging is a no-no #65046

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@kumaraditya303 @miss-islington
pythonGH-65046: Fix docs about logging in asyncio (pythonGH-97559)
1d5ca2a
Explain that logging should not use network I/O.
(cherry picked from commit d68c37c)

Co-authored-by: Kumar Aditya <[email protected]>
@miss-islington
miss-islington requested review from 1st1 and asvetlov as code owners September 26, 2022 22:37
@bedevere-bot bedevere-bot added the skip news label Sep 26, 2022
@bedevere-bot bedevere-bot mentioned this pull request Sep 26, 2022
GH-65046: Fix docs about logging in asyncio #97559
Merged
@bedevere-bot bedevere-bot added awaiting review docs Documentation in the Doc dir labels Sep 26, 2022
gvanrossum
gvanrossum approved these changes Sep 26, 2022
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting review labels Sep 26, 2022
@miss-islington

miss-islington commented Sep 26, 2022

Copy link
Copy Markdown
Contributor Author

Status check is done, and it's a success ✅.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@miss-islington
miss-islington merged commit 82932b3 into python:3.11 Sep 26, 2022
@bedevere-bot bedevere-bot removed the awaiting merge label Sep 26, 2022
@miss-islington
miss-islington deleted the backport-d68c37c-3.11 branch September 26, 2022 22:46
@miss-islington

miss-islington commented Sep 26, 2022

Copy link
Copy Markdown
Contributor Author

Status check is done, and it's a success ✅.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gvanrossum gvanrossum gvanrossum approved these changes
@1st1 1st1 Awaiting requested review from 1st1 1st1 is a code owner
@asvetlov asvetlov Awaiting requested review from asvetlov asvetlov is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@miss-islington @gvanrossum @bedevere-bot @kumaraditya303
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.