GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-97588: Failing tests to demonstrate the issue by matthiasgoergens · Pull Request #97589 · python/cpython

Conversation

@matthiasgoergens

@matthiasgoergens matthiasgoergens commented Sep 27, 2022 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

The tests are expected to fail, and are marked as such.

  • Issue: ctypes: bit field data does not survive round trip #97588

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@matthiasgoergens
pythongh-97588: Some tests to demonstrate the issue
992436d
@bedevere-bot bedevere-bot added awaiting review tests Tests in the Lib/test dir labels Sep 27, 2022
matthiasgoergens added 6 commits September 27, 2022 15:35
@matthiasgoergens
Merge branch 'main' into bitfields
8c8e615
@matthiasgoergens
Merge branch 'main' into bitfields
ee0d8ee
@matthiasgoergens
Merge branch 'main' into bitfields
90365da
@matthiasgoergens
Merge remote-tracking branch 'origin/main' into bitfields
9c12c18
@matthiasgoergens
Merge remote-tracking branch 'matthias/bitfields' into bitfields
af33256
@matthiasgoergens
Mark expected failure
6a46883
@matthiasgoergens matthiasgoergens changed the title gh-97588: Some tests to demonstrate the issue gh-97588: Failing tests to demonstrate the issue Sep 30, 2022
@matthiasgoergens

matthiasgoergens commented Sep 30, 2022

Copy link
Copy Markdown
Contributor Author

@mdickinson I marked the tests as failing, so we cant potentially get them into main as a basis for further work.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
matthiasgoergens and others added 10 commits September 30, 2022 10:26
@matthiasgoergens
Mention the issue
3a03cb8
@matthiasgoergens
Doesn't fail on Windows
0aa3a00
@matthiasgoergens
Test for alignment boundary
f41e7cc
@matthiasgoergens
Rename variables
a77b849
@matthiasgoergens
More failures
923d1ef
@matthiasgoergens
More failures
dd7ddd4
@matthiasgoergens
Merge branch 'main' into bitfields
41a506f
@blurb-it
📜🤖 Added by blurb_it.
e5dfe88
@matthiasgoergens
More failures
ed2e932
@matthiasgoergens
Merge remote-tracking branch 'matthias/bitfields' into bitfields
dee6b90
nanjekyejoannah
nanjekyejoannah reviewed Oct 6, 2022
View reviewed changes

@nanjekyejoannah nanjekyejoannah left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't we be patching a fix instead? Unless we are accepting this as desired behaviour.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@matthiasgoergens

matthiasgoergens commented Oct 6, 2022

Copy link
Copy Markdown
Contributor Author

@nanjekyejoannah See #97702 for the fix.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
nanjekyejoannah
nanjekyejoannah reviewed Oct 7, 2022
View reviewed changes

@nanjekyejoannah nanjekyejoannah left a comment •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Then we close this to merge the fix instead, no?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@matthiasgoergens

matthiasgoergens commented Oct 8, 2022

Copy link
Copy Markdown
Contributor Author

@nanjekyejoannah I'm not completely confident in the fix, yet. But I am confident that these test cases are good.

Not sure we have a general policy against contributing failing test cases?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
nanjekyejoannah
nanjekyejoannah reviewed Oct 11, 2022
View reviewed changes

@nanjekyejoannah nanjekyejoannah left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tests test the failing caes. But with the fix, these tests will change i.e not failing, I would prefer reviewing a PR with a fix and updated tests, since there is a fix. What do you think?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@matthiasgoergens

matthiasgoergens commented Oct 11, 2022

Copy link
Copy Markdown
Contributor Author

@nanjekyejoannah Feel free to review #97702
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@matthiasgoergens
Merge remote-tracking branch 'origin/main' into bitfields
be065d5
@matthiasgoergens
matthiasgoergens force-pushed the bitfields branch from 2acd7a9 to be065d5 Compare March 14, 2023 02:14
@bedevere-bot bedevere-bot mentioned this pull request Mar 14, 2023
ctypes: bit field data does not survive round trip #97588
Closed
@encukou

encukou commented Aug 26, 2024

Copy link
Copy Markdown
Member

These were merged with #97702. Thank you!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@encukou encukou closed this Aug 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nanjekyejoannah nanjekyejoannah nanjekyejoannah left review comments

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

awaiting review tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@matthiasgoergens @encukou @nanjekyejoannah @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.