GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.10] gh-65046: Add note about logging from async code. (GH-97602) (GH-97609) by miss-islington · Pull Request #97609 · python/cpython

Conversation

@miss-islington

@miss-islington miss-islington commented Sep 28, 2022 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

(cherry picked from commit 5c110d1)

Co-authored-by: Vinay Sajip [email protected]

  • Issue: asyncio docs should call out that network logging is a no-no #65046

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@vsajip @miss-islington
pythongh-65046: Add note about logging from async code. (pythonGH-97602)
df6ecc0 
(cherry picked from commit 5c110d1)

Co-authored-by: Vinay Sajip <[email protected]>
@miss-islington
miss-islington requested a review from vsajip as a code owner September 28, 2022 04:18
@bedevere-bot bedevere-bot mentioned this pull request Sep 28, 2022
gh-65046: Add note about logging from async code. (GH-97602) #97602
Merged
@bedevere-bot bedevere-bot added skip news awaiting review docs Documentation in the Doc dir labels Sep 28, 2022
@miss-islington

miss-islington commented Sep 28, 2022

Copy link
Copy Markdown
Contributor Author

Status check is done, and it's a success ✅.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vsajip vsajip changed the title [3.10] gh-65046: Add note about logging from async code. (GH-97602) [3.10] gh-65046: Add note about logging from async code. (GH-97602) (GH-97609) Sep 28, 2022
@vsajip
vsajip merged commit feb4be1 into python:3.10 Sep 28, 2022
@bedevere-bot bedevere-bot removed the awaiting review label Sep 28, 2022
@miss-islington
miss-islington deleted the backport-5c110d1-3.10 branch September 28, 2022 04:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vsajip vsajip Awaiting requested review from vsajip vsajip is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@miss-islington @vsajip @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.