GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-94808: [coverage] Add an asynchronous generator test by zhanpon · Pull Request #97672 · python/cpython

Conversation

@zhanpon

@zhanpon zhanpon commented Sep 30, 2022 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor
  • Issue: Metabug: Improving C-level coverage #94808

The test covers the following code path:

cpython/Objects/genobject.c

Lines 1780 to 1785 in ff54dd9

if (o->ags_gen->ag_running_async) {
PyErr_SetString(
PyExc_RuntimeError,
"anext(): asynchronous generator is already running");
return NULL;
}

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@zhanpon
[coverage] Add an asynchronous generator test
8ce148e 
Cover the error condition of 'asynchronous generator is already running'
@bedevere-bot bedevere-bot added awaiting review tests Tests in the Lib/test dir labels Sep 30, 2022
@mdboom

mdboom commented Sep 30, 2022

Copy link
Copy Markdown
Contributor

Thanks for improving our test coverage! Can you point to the specific lines that this adds coverage for?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@zhanpon

zhanpon commented Sep 30, 2022

Copy link
Copy Markdown
Contributor Author

@mdboom Thank you for the comment! I've added it to the PR description.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@kumaraditya303 kumaraditya303 added the skip news label Oct 1, 2022
kumaraditya303
kumaraditya303 approved these changes Oct 1, 2022
View reviewed changes
@bedevere-bot bedevere-bot added awaiting core review and removed awaiting review labels Oct 1, 2022
@kumaraditya303
kumaraditya303 requested a review from iritkatriel October 3, 2022 15:41
@kumaraditya303
Merge branch 'main' into improve-asyncgen-coverage
abc20d8
@bedevere-bot bedevere-bot mentioned this pull request Nov 24, 2022
Metabug: Improving C-level coverage #94808
Open
kumaraditya303
kumaraditya303 approved these changes Nov 24, 2022
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting core review labels Nov 24, 2022
@kumaraditya303
kumaraditya303 merged commit 5f4ae86 into python:main Nov 24, 2022
@bedevere-bot bedevere-bot removed the awaiting merge label Nov 24, 2022
@kumaraditya303

kumaraditya303 commented Nov 24, 2022

Copy link
Copy Markdown
Contributor

Thanks.
zhanpon reacted with heart emoji
All reactions
  • ❤️ 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@zhanpon
zhanpon deleted the improve-asyncgen-coverage branch November 24, 2022 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kumaraditya303 kumaraditya303 kumaraditya303 approved these changes
@iritkatriel iritkatriel Awaiting requested review from iritkatriel

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@zhanpon @mdboom @kumaraditya303 @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.