GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.11] gh-94732: Fix KeyboardInterrupt race in asyncio run_forever() (GH-97765) by miss-islington · Pull Request #97792 · python/cpython

Conversation

@miss-islington

@miss-islington miss-islington commented Oct 3, 2022 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Ensure that the event loop's _thread_id attribute and the asyncgen hooks set by sys.set_asyncgen_hooks() are always restored no matter where a KeyboardInterrupt exception is raised.
(cherry picked from commit 3a49dbb)

Co-authored-by: hetmankp [email protected]

  • Issue: Race with KeyboardInterrupt in asyncio loop run_forever() method #94732

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@hetmankp @miss-islington
pythongh-94732: Fix KeyboardInterrupt race in asyncio run_forever() (p…
0d7548e
…ythonGH-97765)

Ensure that the event loop's `_thread_id` attribute and the asyncgen hooks set by `sys.set_asyncgen_hooks()` are always restored no matter where a KeyboardInterrupt exception is raised.
(cherry picked from commit 3a49dbb)

Co-authored-by: hetmankp <[email protected]>
@miss-islington
miss-islington requested review from 1st1 and asvetlov as code owners October 3, 2022 20:34
@bedevere-bot bedevere-bot added the skip news label Oct 3, 2022
@bedevere-bot bedevere-bot mentioned this pull request Oct 3, 2022
gh-94732: Fix KeyboardInterrupt race in asyncio run_forever() #97765
Merged
@bedevere-bot bedevere-bot added the awaiting review label Oct 3, 2022
@miss-islington

miss-islington commented Oct 3, 2022

Copy link
Copy Markdown
Contributor Author

Status check is done, and it's a success ✅.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

gvanrossum
gvanrossum approved these changes Oct 3, 2022
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting review labels Oct 3, 2022
@miss-islington
miss-islington merged commit 4420da0 into python:3.11 Oct 3, 2022
@bedevere-bot bedevere-bot removed the awaiting merge label Oct 3, 2022
@miss-islington
miss-islington deleted the backport-3a49dbb-3.11 branch October 3, 2022 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gvanrossum gvanrossum gvanrossum approved these changes
@1st1 1st1 Awaiting requested review from 1st1 1st1 is a code owner
@asvetlov asvetlov Awaiting requested review from asvetlov asvetlov is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@miss-islington @gvanrossum @bedevere-bot @hetmankp
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.