GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.10] gh-94808: Cover `PyObject_PyBytes` case with custom `__bytes__` method (GH-96610) by sobolevn · Pull Request #98121 · python/cpython

Conversation

@sobolevn

@sobolevn sobolevn commented Oct 9, 2022 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Co-authored-by: Jelle Zijlstra [email protected]. (cherry picked from commit e39ae6b)

Co-authored-by: Nikita Sobolev [email protected]

Backporting #96610

  • Issue: Metabug: Improving C-level coverage #94808

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-bot bedevere-bot added awaiting review skip news labels Oct 9, 2022
@bedevere-bot bedevere-bot mentioned this pull request Oct 9, 2022
gh-94808: Cover PyObject_PyBytes case with custom __bytes__ method #96610
Merged
@bedevere-bot bedevere-bot added the tests Tests in the Lib/test dir label Oct 9, 2022
@sobolevn
[3.10] pythongh-94808: Cover PyObject_PyBytes case with custom `__b…
23419ec 
…ytes__` method (pythonGH-96610)

Co-authored-by: Jelle Zijlstra <[email protected]>.
(cherry picked from commit e39ae6b)

Co-authored-by: Nikita Sobolev <[email protected]>
@sobolevn
sobolevn force-pushed the backport-e39ae6b-3.10 branch from 1568968 to 23419ec Compare October 9, 2022 12:02
@sobolevn
sobolevn requested a review from JelleZijlstra October 9, 2022 12:03
@sobolevn

sobolevn commented Oct 9, 2022

Copy link
Copy Markdown
Member Author

Oh, byteorder is required for 3.10. One minute, please!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@sobolevn
Use byteorder param
3fc65b4
JelleZijlstra
JelleZijlstra approved these changes Oct 9, 2022
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting review labels Oct 9, 2022
@JelleZijlstra
JelleZijlstra merged commit ccb5680 into python:3.10 Oct 9, 2022
@bedevere-bot bedevere-bot removed the awaiting merge label Oct 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JelleZijlstra JelleZijlstra JelleZijlstra approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@sobolevn @JelleZijlstra @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.