GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-97669: Remove abitype.py and pep384_macrocheck.py by vstinner · Pull Request #98165 · python/cpython

Conversation

@vstinner

@vstinner vstinner commented Oct 10, 2022 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Remove abitype.py and pep384_macrocheck.py scripts of Tools/scripts/.

  • Issue: Remove outdated Tools/scripts/ example scripts #97669

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@vstinner
gh-97669: Remove abitype.py and pep384_macrocheck.py
9a2f386
Remove abitype.py and pep384_macrocheck.py scripts of Tools/scripts/.
@vstinner vstinner added the skip news label Oct 10, 2022
@bedevere-bot bedevere-bot added the awaiting core review label Oct 10, 2022
@vstinner

vstinner commented Oct 10, 2022

Copy link
Copy Markdown
Member Author

Remove abitype.py and pep384_macrocheck.py scripts of Tools/scripts/.

@encukou @erlend-aasland @corona10: Did one of you ever use one of these scripts? If not, I don't think that they are still relevant.

I didn't know these scripts but I ported many C extensions to heap types, module state and multi-phase init API. I was fine to do a few changes manually.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@vstinner vstinner mentioned this pull request Oct 10, 2022
Remove outdated Tools/scripts/ example scripts #97669
Closed
@erlend-aasland

erlend-aasland commented Oct 11, 2022

Copy link
Copy Markdown
Contributor

Did one of you ever use one of these scripts?

I know about their existence, and I've had a look at them, but I've never used them. Porting C extension modules to module state is not straight-forward.

vstinner reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@encukou

encukou commented Oct 11, 2022

Copy link
Copy Markdown
Member

I've never used them. They seem untested and unused. Let's remove them and if anyone complains, improve them or add the check to CI.

erlend-aasland and vstinner reacted with thumbs up emoji
All reactions
  • 👍 2 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

erlend-aasland
erlend-aasland approved these changes Oct 11, 2022
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting core review labels Oct 11, 2022
@vstinner
vstinner merged commit 454a6d6 into python:main Oct 11, 2022
@bedevere-bot bedevere-bot removed the awaiting merge label Oct 11, 2022
@vstinner
vstinner deleted the remove_pep384_scripts branch October 11, 2022 11:19
@vstinner

vstinner commented Oct 11, 2022

Copy link
Copy Markdown
Member Author

Ok, I removed them. As written in the doc, a copy can be found in the https://github.com/gvanrossum/old-demos project.

Doc: https://docs.python.org/dev/whatsnew/3.12.html#demos-and-tools

I've never used them. They seem untested and unused. Let's remove them and if anyone complains, improve them or add the check to CI.

Right, no doc, no test.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@corona10

corona10 commented Oct 11, 2022

Copy link
Copy Markdown
Member

Oh, I am late, but I never used them. I even don't know their existence.

vstinner reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@erlend-aasland erlend-aasland erlend-aasland approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@vstinner @erlend-aasland @encukou @corona10 @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.