GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.11] gh-97527: IDLE - fix buggy macosx patch (GH-98313) by miss-islington · Pull Request #98329 · python/cpython

Conversation

@miss-islington

@miss-islington miss-islington commented Oct 16, 2022 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

GH-97530 fixed IDLE tests possibly crashing on a Mac without a GUI.
But it resulted in IDLE not starting in 3.10.8, 3.12.0a1, and
Microsoft Python 3.10.2288.0 when test/* is not installed.
After this patch, test.* is only imported when testing on Mac.
(cherry picked from commit 35fa5d5)

Co-authored-by: Terry Jan Reedy [email protected]

  • Issue: IDLE: protect macOS Tk() call when no GUI #97527

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@miss-islington
miss-islington requested a review from terryjreedy as a code owner October 16, 2022 14:23
@bedevere-bot bedevere-bot added the awaiting review label Oct 16, 2022
@bedevere-bot bedevere-bot mentioned this pull request Oct 16, 2022
gh-97527: IDLE - fix buggy macosx patch #98313
Merged
terryjreedy
terryjreedy approved these changes Oct 16, 2022
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting review labels Oct 16, 2022
@terryjreedy @miss-islington
pythongh-97527: IDLE - fix buggy macosx patch (pythonGH-98313)
50ef214
pythonGH-97530 fixed IDLE tests possibly crashing on a Mac without a GUI.
But it resulted in IDLE not starting in 3.10.8, 3.12.0a1, and
Microsoft Python 3.10.2288.0 when test/* is not installed.
After this patch, test.* is only imported when testing on Mac.
(cherry picked from commit 35fa5d5)

Co-authored-by: Terry Jan Reedy <[email protected]>
@miss-islington
miss-islington force-pushed the backport-35fa5d5-3.11 branch from d4a2d06 to 50ef214 Compare October 16, 2022 15:32
@miss-islington

miss-islington commented Oct 16, 2022

Copy link
Copy Markdown
Contributor Author

Sorry, I can't merge this PR. Reason: 6 of 9 required status checks have not succeeded: 5 expected..

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@miss-islington
miss-islington merged commit 21fbf16 into python:3.11 Oct 16, 2022
@bedevere-bot bedevere-bot removed the awaiting merge label Oct 16, 2022
@miss-islington
miss-islington deleted the backport-35fa5d5-3.11 branch October 16, 2022 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@terryjreedy terryjreedy terryjreedy approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@miss-islington @terryjreedy @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.