GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-98401: Reject invalid escape sequences in strings by vstinner · Pull Request #98404 · python/cpython

Conversation

@vstinner

@vstinner vstinner commented Oct 18, 2022 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

A backslash-character pair that is not a valid escape sequence now generates a SyntaxError.

  • Issue: Reject invalid escape sequences (and octal escape sequences) in bytes and Unicode strings #98401

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@vstinner
vstinner requested review from lysnikolaou and pablogsal as code owners October 18, 2022 15:44
@bedevere-bot bedevere-bot added the awaiting core review label Oct 18, 2022
@vstinner vstinner mentioned this pull request Oct 18, 2022
Reject invalid escape sequences (and octal escape sequences) in bytes and Unicode strings #98401
Closed
@vstinner
gh-98401: Reject invalid escape sequences in strings
bd3cb12 
A backslash-character pair that is not a valid escape sequence now
generates a SyntaxError.
@vstinner

vstinner commented Oct 18, 2022

Copy link
Copy Markdown
Member Author

cc @serhiy-storchaka @hugovk
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner
vstinner marked this pull request as draft October 20, 2022 09:45
@vstinner

vstinner commented Oct 20, 2022

Copy link
Copy Markdown
Member Author

I convert this PR to a draft since this change seems to be more controversial than expected: #98401
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner

vstinner commented Nov 2, 2022

Copy link
Copy Markdown
Member Author

PR abandoned in favor of #99011
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner vstinner closed this Nov 2, 2022
@vstinner
vstinner deleted the reject_invalid_escape branch November 2, 2022 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pablogsal pablogsal Awaiting requested review from pablogsal pablogsal is a code owner
@lysnikolaou lysnikolaou Awaiting requested review from lysnikolaou lysnikolaou is a code owner
@AA-Turner AA-Turner Awaiting requested review from AA-Turner AA-Turner will be requested when the pull request is marked ready for review AA-Turner is a code owner
@willingc willingc Awaiting requested review from willingc willingc will be requested when the pull request is marked ready for review willingc is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

awaiting core review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@vstinner @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.