GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.11] gh-98414: py.exe launcher does not use defaults for -V:company/ option (GH-98460) by miss-islington · Pull Request #98468 · python/cpython

Conversation

@miss-islington

@miss-islington miss-islington commented Oct 19, 2022 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

(cherry picked from commit 4bd63f6)

Co-authored-by: Steve Dower [email protected]

  • Issue: test_filter_to_company() in test_launcher fails due to py.ini #98414

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@zooba @miss-islington
pythongh-98414: py.exe launcher does not use defaults for -V:company/…
b650b42 
… option (pythonGH-98460)

(cherry picked from commit 4bd63f6)

Co-authored-by: Steve Dower <[email protected]>
@miss-islington
miss-islington requested a review from a team as a code owner October 19, 2022 22:00
@bedevere-bot bedevere-bot added the awaiting review label Oct 19, 2022
@bedevere-bot bedevere-bot mentioned this pull request Oct 19, 2022
gh-98414: py.exe launcher does not use defaults for -V:company/ option #98460
Merged
@bedevere-bot bedevere-bot added the type-bug An unexpected behavior, bug, or error label Oct 19, 2022
@zooba

zooba commented Oct 19, 2022

Copy link
Copy Markdown
Member

@pablogsal For your consideration for 3.11.0. This was regressed by a fix in one of the RCs that fixed a regression from 3.10. The change itself is simple and logical - if -V: is passed, don't look at any env/ini defaults. But it's also an obscure case in something that didn't exist in 3.10, so it's not strictly a regression from the previous release.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
zooba
zooba approved these changes Oct 19, 2022
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting review labels Oct 19, 2022
@miss-islington
miss-islington merged commit 0b71dad into python:3.11 Oct 19, 2022
@bedevere-bot bedevere-bot removed the awaiting merge label Oct 19, 2022
@miss-islington
miss-islington deleted the backport-4bd63f6-3.11 branch October 19, 2022 22:41
@zooba

zooba commented Oct 19, 2022

Copy link
Copy Markdown
Member

Definitely want it in for 3.11.1 though, so letting the bot do the merge
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zooba zooba zooba approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

type-bug An unexpected behavior, bug, or error

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@miss-islington @zooba @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.