GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-97909 : PyMemberDef members are not marked up by Johnny11502 · Pull Request #98473 · python/cpython

Conversation

@Johnny11502

@Johnny11502 Johnny11502 commented Oct 20, 2022 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor
  • Issue: Some C struct members are not marked up in docs #97909

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Johnny11502 added 2 commits October 19, 2022 21:56
@Johnny11502
Updated the members of PyMemberDef
199c414
@Johnny11502
Updated members of PyMemberDef
acdc0bc
@bedevere-bot bedevere-bot added awaiting review docs Documentation in the Doc dir skip news labels Oct 20, 2022
@Johnny11502

Johnny11502 commented Oct 20, 2022

Copy link
Copy Markdown
Contributor Author

@JelleZijlstra So far it looks good. Thanks for the help!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
kwsp
kwsp reviewed Oct 23, 2022
View reviewed changes

@kwsp kwsp left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I checked the build and the members can be linked to individually.

Since we're on this, should we also fix PyGetSetDef, which is currently also a table? @encukou

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread Doc/c-api/structures.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
@encukou @kwsp
Add doc for PyMemberDef.name
474b2a0 
Co-authored-by: T <[email protected]>
encukou
encukou reviewed Oct 24, 2022
View reviewed changes
Comment thread Doc/c-api/structures.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
@encukou
Remove trailing whitespace from the suggestion
3d4b2f4
@encukou

encukou commented Oct 24, 2022

Copy link
Copy Markdown
Member

Looks good, thanks!

Since we're on this, should we also fix PyGetSetDef, which is currently also a table?

Yup, but it can be a separate PR. I'll add it to the issue.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@encukou
encukou merged commit c237076 into python:main Oct 24, 2022
@bedevere-bot bedevere-bot removed the awaiting review label Oct 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@encukou encukou encukou left review comments
+1 more reviewer
@kwsp kwsp kwsp left review comments
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@Johnny11502 @encukou @kwsp @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.