GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | |||||||||||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | |||||||||||||
GeezerVison is showing github.com — gh-97850: Deprecate `find_loader` and `get_loader` in `pkgutil` by sobolevn · Pull Request #98520 · python/cpython Conversation
|
|
Thank you for the reviews: @merwok and @CAM-Gerlach I've also checked that >>> import pkgutil >>> pkgutil.get_loader('os') <stdin>:1: DeprecationWarning: 'pkgutil.get_loader' is deprecated and slated for removal in Python 3.14; use importlib.util.find_spec instead <_frozen_importlib_external.SourceFileLoader object at 0x1012d55f0> >>>
I've also merged one of the @CAM-Gerlach's suggestion, so you get a credit for your awesome proposals! 🤝 |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
Overall LGTM, but I think there might be some unnecessary checks in the tests for various module "kinds".
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
Just FYI, you can apply some or all of them at once by going to the |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
…m/sobolevn/cpython into deprecate-pkgutil-get-find-loader
|
@brettcannon I forgot to send the magic phrase! I have made the requested changes; please review again |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Thanks for making the requested changes! @brettcannon: please review the changes made to this pull request. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
Unfortunately I just realized that the documentation for pkgutil needs updating to mention the deprecations.
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
Co-authored-by: Brett Cannon <[email protected]>
find_module and get_module in pkgutilfind_loader and get_loader in pkgutil
…6coo.rst Co-authored-by: Brett Cannon <[email protected]>
|
I have made the requested changes; please review again 🙂 |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Thanks for making the requested changes! @brettcannon: please review the changes made to this pull request. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Oups, just found out that my push with Redid it now, it worked! |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
|
@sobolevn the changes look good, but now there are unfortunately merge conflicts. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Done :) |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Thanks! |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Thank you for this additional cleanup! |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
Successfully merging this pull request may close these issues.
There was an error while loading. Please reload this page.