GeezerVison is showing github.com — GH-98363: Fix exception handling in batched() by rhettinger · Pull Request #98523 · python/cpython
Conversation
rhettinger
commented
Oct 21, 2022
•
edited by bedevere-bot
Loading
Uh oh!
There was an error while loading. Please reload this page.
Was erring out when an input iterator raised an exception other than StopIteration.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
|
The inner loop is now optimally fast and clean:
LBB55_4:
mov x0, x22 ; x0 <- it
blr x24 ; x0 <- iternext(it);
cbz x0, LBB55_7 ; if (item == NULL) goto null_item;
str x0, [x25, x21, lsl #3] ; items[i] = item;
add x21, x21, #1 ; i++
cmp x23, x21 ; i < n
b.ne LBB55_4
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Assignees
No one assigned
Milestone
No milestone
Development
Successfully merging this pull request may close these issues.
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.