GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.11] GH-87390: Add remaining tests for PEP 646 (GH-98267) by JelleZijlstra · Pull Request #98667 · python/cpython

Conversation

@JelleZijlstra

@JelleZijlstra JelleZijlstra commented Oct 25, 2022 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Co-authored-by: Guido van Rossum [email protected]. (cherry picked from commit cb95cc2)

Co-authored-by: Matthew Rahtz [email protected]

  • Issue: Add support for PEP 646 #87390

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@mrahtz @JelleZijlstra
[3.11] pythonGH-87390: Add remaining tests for PEP 646 (pythonGH-98267)
fc6f7cf 
Co-authored-by: Guido van Rossum <[email protected]>.
(cherry picked from commit cb95cc2)

Co-authored-by: Matthew Rahtz <[email protected]>
@JelleZijlstra
JelleZijlstra requested review from AlexWaygood, Fidget-Spinner and gvanrossum as code owners October 25, 2022 14:48
@bedevere-bot bedevere-bot added the awaiting core review label Oct 25, 2022
@bedevere-bot bedevere-bot mentioned this pull request Oct 25, 2022
GH-87390: Add remaining tests for PEP 646 #98267
Merged
@bedevere-bot bedevere-bot added the tests Tests in the Lib/test dir label Oct 25, 2022
JelleZijlstra
JelleZijlstra commented Oct 25, 2022
View reviewed changes
Comment thread Lib/test/test_typing.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
JelleZijlstra
JelleZijlstra commented Oct 25, 2022
View reviewed changes
Comment thread Lib/test/test_typing.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
@JelleZijlstra JelleZijlstra self-assigned this Oct 25, 2022
@armw4

This comment was marked as off-topic.

Sign in to view
@gvanrossum

gvanrossum commented Oct 25, 2022

Copy link
Copy Markdown
Member

I'd like to decline reviewing this. I need to shed load.
AlexWaygood reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@gvanrossum
gvanrossum removed their request for review October 25, 2022 18:41
@JelleZijlstra
fix test
21ff4f0
@JelleZijlstra
JelleZijlstra merged commit 83c8df2 into python:3.11 Oct 26, 2022
@bedevere-bot bedevere-bot removed the awaiting core review label Oct 26, 2022
@JelleZijlstra
JelleZijlstra deleted the backport-cb95cc2-3.11 branch October 26, 2022 01:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Fidget-Spinner Fidget-Spinner Awaiting requested review from Fidget-Spinner
@AlexWaygood AlexWaygood Awaiting requested review from AlexWaygood AlexWaygood is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@JelleZijlstra JelleZijlstra

Labels

tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@JelleZijlstra @armw4 @gvanrossum @bedevere-bot @mrahtz
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.