GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-98817: Remove PCbuild/lib.pyproj by hugovk · Pull Request #98818 · python/cpython

Conversation

@hugovk

@hugovk hugovk commented Oct 28, 2022 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • Issue: Remove PCbuild/lib.pyproj #98817

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@hugovk
hugovk requested a review from a team as a code owner October 28, 2022 15:54
@bedevere-bot bedevere-bot added the awaiting review label Oct 28, 2022
@hugovk hugovk changed the title #98817 Remove PCbuild/lib.pyproj gh-98817: Remove PCbuild/lib.pyproj Oct 28, 2022
@zooba

zooba commented Oct 28, 2022

Copy link
Copy Markdown
Member

Can you move the NEWS entry under Build rather than Windows? This only affects people building Python, not any Windows users.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@hugovk

hugovk commented Oct 28, 2022

Copy link
Copy Markdown
Member Author

Moved!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@hugovk
hugovk force-pushed the rm-lib.pyproj branch from 1a4af21 to 4a8d0d7 Compare October 28, 2022 16:08
zooba
zooba approved these changes Oct 28, 2022
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting review labels Oct 28, 2022
@hugovk
Remove PCbuild/lib.pyproj
d0aae7e
@hugovk
hugovk force-pushed the rm-lib.pyproj branch from 4a8d0d7 to d0aae7e Compare November 4, 2022 12:59
@bedevere-bot bedevere-bot mentioned this pull request Nov 4, 2022
Remove PCbuild/lib.pyproj #98817
Closed
@hugovk

hugovk commented Nov 4, 2022

Copy link
Copy Markdown
Member Author

Rebased to resolve merge conflict.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@zooba
zooba merged commit 9430d27 into python:main Nov 7, 2022
@bedevere-bot bedevere-bot removed the awaiting merge label Nov 7, 2022
@hugovk
hugovk deleted the rm-lib.pyproj branch November 8, 2022 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zooba zooba zooba approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@hugovk @zooba @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.