GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — GH-90699: Remove `_Py_IDENTIFIER` usage from `_json` module by kumaraditya303 · Pull Request #98956 · python/cpython

Conversation

@kumaraditya303

@kumaraditya303 kumaraditya303 commented Nov 1, 2022 •
edited by miss-islington
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor
  • Issue: Replace _Py_IDENTIFIER() with statically initialized objects. #90699

Automerge-Triggered-By: GH:ericsnowcurrently

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@kumaraditya303
port json
75a2b4a
@bedevere-bot bedevere-bot mentioned this pull request Nov 1, 2022
Replace _Py_IDENTIFIER() with statically initialized objects. #90699
Closed
@bedevere-bot bedevere-bot added the awaiting review label Nov 1, 2022
@kumaraditya303 kumaraditya303 added the skip news label Nov 1, 2022
kumaraditya303 added 3 commits November 1, 2022 11:36
@kumaraditya303
restore comment
94c765d
@kumaraditya303
regen
ac99ed4
@kumaraditya303
add comment
e1d3840
Fidget-Spinner
Fidget-Spinner reviewed Nov 1, 2022
View reviewed changes
Comment thread Modules/_json.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
@kumaraditya303
even more strings
a3f7d24
@kumaraditya303
kumaraditya303 requested a review from ericsnowcurrently November 2, 2022 10:58
@kumaraditya303
Merge branch 'main' into json
78f662c
ericsnowcurrently
ericsnowcurrently approved these changes Nov 2, 2022
View reviewed changes

@ericsnowcurrently ericsnowcurrently left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting review labels Nov 2, 2022
@ericsnowcurrently ericsnowcurrently added the 🤖 automerge label Nov 2, 2022
@miss-islington
miss-islington merged commit 780757a into python:main Nov 2, 2022
@bedevere-bot bedevere-bot removed the awaiting merge label Nov 2, 2022
@kumaraditya303
kumaraditya303 deleted the json branch November 2, 2022 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Fidget-Spinner Fidget-Spinner Fidget-Spinner left review comments
@ericsnowcurrently ericsnowcurrently ericsnowcurrently approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@kumaraditya303 @ericsnowcurrently @Fidget-Spinner @bedevere-bot @miss-islington
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.