GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — GH-90699: Remove `_Py_IDENTIFIER` usage from `_ctypes` by kumaraditya303 · Pull Request #99054 · python/cpython

Conversation

@kumaraditya303

@kumaraditya303 kumaraditya303 commented Nov 3, 2022 •
edited by miss-islington
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor
  • Issue: Replace _Py_IDENTIFIER() with statically initialized objects. #90699

Automerge-Triggered-By: GH:ericsnowcurrently

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
kumaraditya303 added 2 commits November 3, 2022 10:40
@kumaraditya303
port ctypes
e1a8968
@kumaraditya303
regen
9f626af
@bedevere-bot bedevere-bot mentioned this pull request Nov 3, 2022
Replace _Py_IDENTIFIER() with statically initialized objects. #90699
Closed
@bedevere-bot bedevere-bot added the awaiting review label Nov 3, 2022
@kumaraditya303 kumaraditya303 added the skip news label Nov 3, 2022
kumaraditya303 added 2 commits November 3, 2022 11:13
@kumaraditya303
fix import
f1ef62b
@kumaraditya303
fix include
671bfba
@kumaraditya303 kumaraditya303 added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Nov 3, 2022
@bedevere-bot

bedevere-bot commented Nov 3, 2022

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @kumaraditya303 for commit 671bfba 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Nov 3, 2022
@kumaraditya303
kumaraditya303 marked this pull request as ready for review November 3, 2022 13:26
@kumaraditya303
kumaraditya303 requested a review from ericsnowcurrently November 3, 2022 13:26
@kumaraditya303 kumaraditya303 mentioned this pull request Nov 3, 2022
GH-90699: Remove remaining _Py_IDENTIFIER stdlib usage #99067
Merged
ericsnowcurrently
ericsnowcurrently approved these changes Nov 3, 2022
View reviewed changes

@ericsnowcurrently ericsnowcurrently left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting review labels Nov 3, 2022
@ericsnowcurrently ericsnowcurrently added the 🤖 automerge label Nov 3, 2022
@miss-islington
miss-islington merged commit 0ee59a9 into python:main Nov 3, 2022
@bedevere-bot bedevere-bot removed the awaiting merge label Nov 3, 2022
@kumaraditya303
kumaraditya303 deleted the ctypes branch November 4, 2022 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ericsnowcurrently ericsnowcurrently ericsnowcurrently approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@kumaraditya303 @bedevere-bot @ericsnowcurrently @miss-islington
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.