GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-73691: Increase size limits in _xxtestfuzz by gpshead · Pull Request #99070 · python/cpython

Conversation

@gpshead

@gpshead gpshead commented Nov 3, 2022 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Now that our int<->str conversions are size limited and we have the _pylong module handling larger integers, we don't need to limit everything just to avoid wasting time in the quadratic time DoS-like case while fuzzing.

We can tweak these further after seeing how this goes.

  • Releated Issue: Quadratic time internal base conversions #90716
  • Issue: Submit the re, json, csv, & struct modules to oss-fuzz testing #73691

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@gpshead
Increase size limits in _xxtestfuzz.
043cb05 
Now that our int<->str conversions are size limited and we have the
_pylong module handling larger integers, we don't need to limit
everything just to avoid wasting time in the quadratic time DoS-like
case while fuzzing.

We can tweak these further after seeing how this goes.
@gpshead gpshead self-assigned this Nov 3, 2022
@bedevere-bot bedevere-bot mentioned this pull request Nov 3, 2022
Quadratic time internal base conversions #90716
Closed
@bedevere-bot bedevere-bot added the awaiting core review label Nov 3, 2022
@gpshead gpshead added the skip news label Nov 3, 2022
@gpshead
gpshead marked this pull request as ready for review November 3, 2022 19:24
@gpshead
gpshead requested a review from ammaraskar November 3, 2022 19:24
@gpshead gpshead changed the title gh-90716: Increase size limits in _xxtestfuzz gh-73691: Increase size limits in _xxtestfuzz Nov 3, 2022
@bedevere-bot bedevere-bot mentioned this pull request Nov 3, 2022
Submit the re, json, csv, & struct modules to oss-fuzz testing #73691
Closed
@gpshead
restore original comment, no need to edit it
8dcc689
ammaraskar
ammaraskar approved these changes Nov 3, 2022
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting core review labels Nov 3, 2022
@ammaraskar

ammaraskar commented Nov 3, 2022

Copy link
Copy Markdown
Member

Sounds good to me :)
gpshead reacted with hooray emoji
All reactions
  • 🎉 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
gpshead added 2 commits November 3, 2022 12:28
@gpshead
comment typo
c95a5d9
@gpshead
Merge branch 'main' into json-fuzzier
4d6a237
@gpshead
gpshead merged commit bee1070 into python:main Nov 3, 2022
@bedevere-bot bedevere-bot removed the awaiting merge label Nov 3, 2022
@gpshead
gpshead deleted the json-fuzzier branch November 3, 2022 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ammaraskar ammaraskar ammaraskar approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@gpshead gpshead

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@gpshead @ammaraskar @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.