GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-90716: bugfixes and more tests for _pylong. by gpshead · Pull Request #99073 · python/cpython

Conversation

@gpshead

@gpshead gpshead commented Nov 3, 2022 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • Properly decref on _pylong import error.
  • Improve the error message on _pylong TypeError.
  • Tie the return value comments together.

These are minor followups to issues not caught among the reviewers on #96673.

  • Issue: Quadratic time internal base conversions #90716

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@gpshead
pythongh-90716: bugfixes and more tests for _pylong.
d0de40f 
* Properly decref on _pylong import error.
* Improve the error message on _pylong TypeError.
* Tie the return value comments together.

These are minor followups to issues not caught among the reviewers on
python#96673.
@bedevere-bot bedevere-bot mentioned this pull request Nov 3, 2022
Quadratic time internal base conversions #90716
Closed
@bedevere-bot bedevere-bot added the awaiting core review label Nov 3, 2022
@gpshead
gpshead requested a review from nascheme November 3, 2022 19:22
@gpshead gpshead added the skip news label Nov 3, 2022
@gpshead
gpshead marked this pull request as ready for review November 3, 2022 19:22
gpshead referenced this pull request Nov 3, 2022
@nascheme
gh-90716: add _pylong.py module (#96673)
de69816 
Add Python implementations of certain longobject.c functions. These use
asymptotically faster algorithms that can be used for operations on
integers with many digits. In those cases, the performance overhead of
the Python implementation is not significant since the asymptotic
behavior is what dominates runtime. Functions provided by this module
should be considered private and not part of any public API.

Co-author: Tim Peters <[email protected]>
Co-author: Mark Dickinson <[email protected]>
Co-author: Bjorn Martinsson
@nascheme

nascheme commented Nov 3, 2022

Copy link
Copy Markdown
Member

Aside from the cpython_only concern, this LTGM.
gpshead reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@gpshead
mark the new tests cpython_only
fdc71c5 
As they covers cpython internal details.
nascheme
nascheme approved these changes Nov 3, 2022
View reviewed changes
Comment thread Lib/test/test_int.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting core review labels Nov 3, 2022
@gpshead
Fix the assertion error in pydebug builds
5320f3b 
by adding the same check and TypeError on the to_decimal_string side.
@gpshead
gpshead merged commit 4c4b5ce into python:main Nov 3, 2022
@bedevere-bot bedevere-bot removed the awaiting merge label Nov 3, 2022
@gpshead
gpshead deleted the _pylong_pr_followup_fixes branch November 3, 2022 23:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nascheme nascheme nascheme approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@gpshead @nascheme @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.