GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-90716: Fix pylong_int_from_string() refleak by vstinner · Pull Request #99094 · python/cpython

Conversation

@vstinner

@vstinner vstinner commented Nov 4, 2022 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Fix validated by:

$ ./python -m test -R 3:3 test_int
Tests result: SUCCESS
  • Issue: Quadratic time internal base conversions #90716

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@vstinner
gh-90716: Fix pylong_int_from_string() refleak
1cbba5c 
Fix validated by:

    $ ./python -m test -R 3:3 test_int
    Tests result: SUCCESS
@vstinner vstinner added the skip news label Nov 4, 2022
@bedevere-bot bedevere-bot mentioned this pull request Nov 4, 2022
Quadratic time internal base conversions #90716
Closed
@bedevere-bot bedevere-bot added the awaiting core review label Nov 4, 2022
@vstinner

vstinner commented Nov 4, 2022

Copy link
Copy Markdown
Member Author

cc @gpshead
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
kumaraditya303
kumaraditya303 approved these changes Nov 4, 2022
View reviewed changes

@kumaraditya303 kumaraditya303 left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@vstinner
vstinner merged commit 387f725 into python:main Nov 4, 2022
@bedevere-bot bedevere-bot removed the awaiting core review label Nov 4, 2022
@vstinner
vstinner deleted the int_str branch November 4, 2022 13:24
@gpshead

gpshead commented Nov 4, 2022

Copy link
Copy Markdown
Member

Heh, thanks!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner

vstinner commented Nov 4, 2022

Copy link
Copy Markdown
Member Author

I wrote an article on this fix :-) https://vstinner.github.io/debug-python-refleak.html

Heh, thanks!

From what I understood, the refleak existed before 4c4b5ce. It's just that thanks to the added test, the Refleaks buildbot spotted the leak.
gpshead and JulienPalard reacted with heart emoji
All reactions
  • ❤️ 2 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kumaraditya303 kumaraditya303 kumaraditya303 approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@vstinner @gpshead @kumaraditya303 @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.