GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — GH-98831: Auto-generate PREDICTED() macro calls by gvanrossum · Pull Request #99102 · python/cpython

Conversation

@gvanrossum

@gvanrossum gvanrossum commented Nov 4, 2022 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

This allows us to remove all PREDICTED() calls from bytecodes.c. The generated_cases.c.h file is unchanged.

  • Issue: Generate the interpreter #98831

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@gvanrossum
Auto-generate PREDICTED() macro calls
47d77ac 
This allows us to remove all PREDICTED() calls from bytecodes.c.
The generated_cases.c.h file is unchanged.
@gvanrossum
gvanrossum requested review from brandtbucher and markshannon November 4, 2022 17:12
@bedevere-bot bedevere-bot mentioned this pull request Nov 4, 2022
Generate the interpreter #98831
Closed
@bedevere-bot bedevere-bot added the awaiting core review label Nov 4, 2022
@gvanrossum gvanrossum mentioned this pull request Nov 4, 2022
GH-98831: Implement super-instruction generation #99084
Merged
brandtbucher
brandtbucher approved these changes Nov 4, 2022
View reviewed changes

@brandtbucher brandtbucher left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

This is exactly the sort of clean improvement I was hoping we could get out of this project... excited for more.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread Tools/cases_generator/generate_cases.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting core review labels Nov 4, 2022
@gvanrossum @brandtbucher
use non capturing group
15b78f0 
Co-authored-by: Brandt Bucher <[email protected]>
@gvanrossum gvanrossum added the skip news label Nov 4, 2022
@gvanrossum
gvanrossum merged commit c885623 into python:main Nov 4, 2022
@bedevere-bot bedevere-bot removed the awaiting merge label Nov 4, 2022
@gvanrossum
gvanrossum deleted the rm-predicted branch November 4, 2022 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@brandtbucher brandtbucher brandtbucher approved these changes
@markshannon markshannon Awaiting requested review from markshannon markshannon is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@gvanrossum @brandtbucher @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.