GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-86018 Inconsistent errors for JSON-encoding NaNs with allow_nan=False by WillAyd · Pull Request #99172 · python/cpython

Conversation

@WillAyd

@WillAyd WillAyd commented Nov 6, 2022 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Fix issue where json.dumps provided a different error message than json.dump with non-finite values

  • Issue: Inconsistent errors for JSON-encoding NaNs with allow_nan=False #86018

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-bot bedevere-bot mentioned this pull request Nov 6, 2022
Inconsistent errors for JSON-encoding NaNs with allow_nan=False #86018
Closed
@bedevere-bot bedevere-bot added the awaiting review label Nov 6, 2022
@WillAyd
pythongh-86018 Inconsistent errors for JSON-encoding NaNs with allow_…
17901af 
…nan=False

Fix issue where json.dumps provided a different error message than json.dump
with non-finite values
@WillAyd
WillAyd force-pushed the json-better-error branch from 4ade4c0 to 17901af Compare November 6, 2022 20:02
sobolevn
sobolevn reviewed Nov 7, 2022
View reviewed changes
Comment thread Misc/NEWS.d/next/Library/2022-11-06-19-59-56.gh-issue-86018.xAt6g2.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Modules/_json.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
WillAyd added 2 commits November 7, 2022 10:36
@WillAyd
suggestions
0d2798e
@WillAyd
simplified implementation
4b8516c
@WillAyd WillAyd closed this Oct 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sobolevn sobolevn sobolevn left review comments

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

awaiting review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@WillAyd @sobolevn @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.