GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — GH-90699: disallow `_Py_IDENTIFIER` in core code by kumaraditya303 · Pull Request #99210 · python/cpython

Conversation

@kumaraditya303

@kumaraditya303 kumaraditya303 commented Nov 7, 2022 •
edited by miss-islington
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor
  • Issue: Replace _Py_IDENTIFIER() with statically initialized objects. #90699

Automerge-Triggered-By: GH:ericsnowcurrently

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-bot bedevere-bot mentioned this pull request Nov 7, 2022
Replace _Py_IDENTIFIER() with statically initialized objects. #90699
Closed
@bedevere-bot bedevere-bot added the awaiting review label Nov 7, 2022
@kumaraditya303 kumaraditya303 added skip news and removed awaiting review labels Nov 7, 2022
@kumaraditya303
kumaraditya303 requested a review from ericsnowcurrently November 7, 2022 18:09
@kumaraditya303
disallow _Py_IDENTIFIER
886ea7b
@kumaraditya303
kumaraditya303 force-pushed the disable-id branch from 6e3330e to 886ea7b Compare November 8, 2022 05:37
@kumaraditya303
kumaraditya303 marked this pull request as ready for review November 8, 2022 05:52
ericsnowcurrently
ericsnowcurrently reviewed Nov 8, 2022
View reviewed changes
Comment thread Programs/_testembed.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
kumaraditya303 added 2 commits November 9, 2022 13:24
@kumaraditya303
Merge branch 'main' of https://github.com/python/cpython into disable-id
4609aab
@kumaraditya303
add comment
aa158d1
ericsnowcurrently
ericsnowcurrently approved these changes Nov 9, 2022
View reviewed changes

@ericsnowcurrently ericsnowcurrently left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-bot bedevere-bot added the awaiting merge label Nov 9, 2022
@ericsnowcurrently ericsnowcurrently added the 🤖 automerge label Nov 9, 2022
@miss-islington
miss-islington merged commit 6e3cc72 into python:main Nov 9, 2022
@bedevere-bot bedevere-bot removed the awaiting merge label Nov 9, 2022
@ericsnowcurrently

ericsnowcurrently commented Nov 9, 2022

Copy link
Copy Markdown
Member

Thanks for working on this, @kumaraditya303!
kumaraditya303 reacted with heart emoji
All reactions
  • ❤️ 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@kumaraditya303
kumaraditya303 deleted the disable-id branch November 9, 2022 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ericsnowcurrently ericsnowcurrently ericsnowcurrently approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@kumaraditya303 @ericsnowcurrently @bedevere-bot @miss-islington
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.