GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-90868: Adjust the Generated Objects by ericsnowcurrently · Pull Request #99223 · python/cpython

Conversation

@ericsnowcurrently

@ericsnowcurrently ericsnowcurrently commented Nov 8, 2022 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

We do the following:

  • move the generated _PyUnicode_InitStaticStrings() to its own file
  • move the generated _PyStaticObjects_CheckRefcnt() to its own file
  • include pycore_global_objects.h in extension modules instead of pycore_runtime_init.h

These changes help us avoid including things that aren't needed.

  • Issue: Share global string identifiers in deepfreeze #90868

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@ericsnowcurrently ericsnowcurrently added the skip news label Nov 8, 2022
@ericsnowcurrently
ericsnowcurrently requested review from a team, 1st1, asvetlov and gvanrossum as code owners November 8, 2022 01:17
@bedevere-bot bedevere-bot mentioned this pull request Nov 8, 2022
Share global string identifiers in deepfreeze #90868
Closed
@bedevere-bot bedevere-bot added the awaiting core review label Nov 8, 2022
ericsnowcurrently added 6 commits November 7, 2022 18:27
@ericsnowcurrently
Do not include pycore_runtime_init.h in modules.
b3f0b39
@ericsnowcurrently
Add pycore_unicodeobject_generated.h.
71e0e37
@ericsnowcurrently
Ignore the generated files.
9997f6b
@ericsnowcurrently
Generate pycore_unicodeobject_generated.h and use it.
739ebe9
@ericsnowcurrently
Add pycore_global_objects_fini_generated.h.
c680298
@ericsnowcurrently
Generate pycore_global_objects_fini_generated.h and use it.
aa76fcc
@ericsnowcurrently
ericsnowcurrently force-pushed the generated-objects-cleanup branch from 6e434d8 to aa76fcc Compare November 8, 2022 01:27
@ericsnowcurrently
ericsnowcurrently removed request for a team, 1st1, asvetlov and gvanrossum November 8, 2022 01:28
@ericsnowcurrently
ericsnowcurrently merged commit 52f91c6 into python:main Nov 8, 2022
@ericsnowcurrently
ericsnowcurrently deleted the generated-objects-cleanup branch November 8, 2022 17:03
@bedevere-bot bedevere-bot removed the awaiting core review label Nov 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@ericsnowcurrently @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.